Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/Add Support For Ruby 3.4. #115

Merged
merged 2 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: ['3.1', '3.2', '3.3']
ruby-version: ['3.1', '3.2', '3.3', '3.4']

steps:
- uses: actions/checkout@v4
Expand All @@ -35,10 +35,6 @@ jobs:

rspec_each:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
ruby-version: ['3.1', '3.2', '3.3']

steps:
- uses: actions/checkout@v4
Expand All @@ -47,7 +43,7 @@ jobs:
# change this to (see https://github.com/ruby/setup-ruby#versioning):
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
ruby-version: '3.1'
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Setup RSpec configuration
run: cp .rspec.example .rspec
Expand Down
8 changes: 4 additions & 4 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,26 @@ source 'https://rubygems.org'

gemspec

gem 'sleeping_king_studios-tasks', '~> 0.4', '>= 0.4.1'
gem 'sleeping_king_studios-tools',
'>= 1.2.0.alpha',
git: 'https://github.com/sleepingkingstudios/sleeping_king_studios-tools.git',
branch: 'main'
gem 'sleeping_king_studios-tasks', '~> 0.4', '>= 0.4.1'
gem 'sleeping_king_studios-yard',
git: 'https://github.com/sleepingkingstudios/sleeping_king_studios-yard.git',
branch: 'main'

group :development, :test do
gem 'byebug', '~> 11.1'

gem 'rspec', '~> 3.13'
gem 'rspec', '~> 3.13'
gem 'rspec-sleeping_king_studios',
'>= 2.8.0.alpha',
git: 'https://github.com/sleepingkingstudios/rspec-sleeping_king_studios.git',
branch: 'main'

gem 'rubocop', '~> 1.66'
gem 'rubocop-rspec', '~> 3.0'
gem 'rubocop', '~> 1.69'
gem 'rubocop-rspec', '~> 3.3'

gem 'simplecov', '~> 0.22'
end
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ On the opposite end of the scale, frameworks such as [Dry::Monads](https://dry-r

## Compatibility

Cuprum is tested against Ruby (MRI) 3.1 through 3.3.
Cuprum is tested against Ruby (MRI) 3.1 through 3.4.

## Documentation

Expand Down
2 changes: 0 additions & 2 deletions spec/cuprum/utils/instance_spy_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,6 @@
expect(spy).not_to be instance_spy
end

# rubocop:disable Style/RedundantLineContinuation
it 'should instrument calls to #call on the subclass',
:aggregate_failures \
do
Expand All @@ -381,7 +380,6 @@
expect(instance_spy).to have_received(:call).with(*command_arguments)
expect(spy).to have_received(:call).with(*command_arguments)
end
# rubocop:enable Style/RedundantLineContinuation

it 'should not instrument calls in other threads' do
allow(instance_spy).to receive(:call)
Expand Down
2 changes: 0 additions & 2 deletions spec/support/examples/processing_examples.rb
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ module ProcessingExamples
end
end

# rubocop:disable Style/RedundantLineContinuation
it 'should forward all arguments to the implementation',
:aggregate_failures \
do
Expand All @@ -107,7 +106,6 @@ module ProcessingExamples
expect(called_arguments).to be == [*arguments, keywords]
expect(yielded).to be true
end
# rubocop:enable Style/RedundantLineContinuation
end

wrap_context 'when the implementation is defined' do
Expand Down
Loading