refactor: Improved logging behavior #216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the logging behavior of ffmpeg-normalize when used via API/python import.
With the current implementation, the logging configuration of ffmpeg-normalize overwrites the root logging behavior even if it's used via python import. For example, the (now deleted) section
added the ANSI color codes to all log messages and the entire output of ffmpeg-normalize is put into the log of the application that imports it. However, in most cases the developers might want to configure this behavior.
With this implementation, you can choose whether or whether not to use the logging output of ffmpeg-normalize. To enable the log output, the following code section (or similar) is necessary:
Please note that the CLI logging behavior of ffmpeg-normalize doesn't change with this PR. I'm configuring the logger in the CLI entrypoint in the same way as it was before (with the help of colorlog