Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "-hide_banner" remove "-nostdin" #222

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Add "-hide_banner" remove "-nostdin" #222

merged 1 commit into from
Mar 15, 2023

Conversation

WyattBlue
Copy link
Contributor

The -nostdin option is unnessary because of the -y option. Adding -hide_banner makes DEBUG statements shorter.

The `-nostdin` option is unnessary because of the `-y` option.
Adding `-hide_banner` makes DEBUG statements shorter.
@slhck
Copy link
Owner

slhck commented Mar 14, 2023

Actually the banner is quite relevant, as it gives you (or me) information about the ffmpeg build used. There are many people who use outdated ffmpeg builds (e.g. from an old distro package) or don't have certain encoders built in. Is there a particular reason why you wouldn't want it in the output?

As for the -nostdin option, I guess this works, as there probably isn't any other reason for ffmpeg to ask for user input other than when overwriting the output file, but I don't know for sure. Doesn't hurt to keep it in there?

@WyattBlue
Copy link
Contributor Author

This PR only reduces the banners printed from 5 to 2.
The danger of having both -y and -nostdin is that they are two answers to the same question: what happens when a prompt is asked? The fact that -y has higher precedence than -nostdin should not always be assumed going forward. Removing -nostdin when both -y and -nostdin are present is simply making explicit what we are already assumming.

@slhck
Copy link
Owner

slhck commented Mar 15, 2023

Ah, got it, I thought it removed it entirely.

@slhck slhck merged commit 831e5c2 into slhck:master Mar 15, 2023
@slhck
Copy link
Owner

slhck commented Mar 15, 2023

Released as 1.26.5

@WyattBlue WyattBlue deleted the patch-1 branch March 16, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants