Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use requirements.txt in setup.py #223

Closed
wants to merge 1 commit into from
Closed

Use requirements.txt in setup.py #223

wants to merge 1 commit into from

Conversation

WyattBlue
Copy link
Contributor

This puts all dependencies in one place without repeating ourselves.
I also changed "Development Status" to stable since we care about backwards compatibly and since this program seems stable 😄

@slhck
Copy link
Owner

slhck commented Mar 16, 2023

Sure, that's reasonable! As for the requirements vs. setup.py issue, I believe the best way would be to have setup.py specify abstract dependencies (i.e. without version pins), and requirements.txt to include the specific version pins we need. At least that's what I see recommended in various places. I pushed changes to master directly!

@slhck slhck closed this Mar 16, 2023
@WyattBlue WyattBlue deleted the patch-2 branch March 16, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants