fix capping to [1, 50] instead of [1, 7] #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, you're right. Will get to it tomorrow. Thanks for the PR! |
|
you're welcome, I'm glad to help out. |
|
Released as v1.27.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the last commits introduced a capping of
input_lrato[1, 7], but this has issues with songs havinginput_lra > 7as setting a lowerLRAthaninput_lraforcesffmpegtoDynamicloudness correction. (I guess it was a mind-twist with theLRA=7.0required for the EBU Standard.)I hope it is ok that I directly created a PR, but as this breaks the
--keep-loudness-range-targetflag, I wanted to introduce a fix as soon as I saw and validated the issue.If I am wrong, please just close the PR. In this case I am sorry for the hassle.