Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on Windows failed due to character conversion #244

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

psavva
Copy link
Contributor

@psavva psavva commented Jul 12, 2023

Defined encoding to utf8 for the README.md and CHANGELOG.md files

@slhck
Copy link
Owner

slhck commented Jul 12, 2023

Thanks for the PR. Didn't know this was necessary, as it works by default under Unix.

@slhck slhck merged commit 62d6229 into slhck:master Jul 12, 2023
@slhck
Copy link
Owner

slhck commented Jul 12, 2023

(Ugh, I guess I have to change this for most of my setup.py files 😅 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants