Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support xcresulttool from Xcode 16 #10

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Support xcresulttool from Xcode 16 #10

merged 7 commits into from
Oct 29, 2024

Conversation

jozefizso
Copy link
Member

@jozefizso jozefizso commented Oct 29, 2024

When using Xcode 16 the commands xcresulttool get and xcresulttool export require new parameter --legacy to be set.

We add the --legacy parameter only for Xcode 16 and we will see what will happen with Xcode 17.

Fixes #5

@jozefizso jozefizso added bug Something isn't working enhancement New feature or request labels Oct 29, 2024
@jozefizso jozefizso self-assigned this Oct 29, 2024
@jozefizso jozefizso requested a review from DominikPalo October 29, 2024 15:37
@jozefizso jozefizso merged commit 032c0ce into main Oct 29, 2024
15 of 33 checks passed
@jozefizso jozefizso deleted the fix/5_xcode16_support branch October 29, 2024 15:56
@teameh
Copy link

teameh commented Dec 4, 2024

Thanks for forking this repo and fixing things. Do you plan on merging it back into kishikawakatsumi's ? If not, perhaps consider changing the readme and usage instructions to point to your version,.

I can't create a new issue on this repo.. so forgive me for commenting my issue here.

When using this config:

      - name: Test
        run: |
          xcodebuild test-without-building \
            -sdk iphoneos \
            -scheme MyScheme \
            -workspace MyScheme.xcworkspace \
            -destination "platform=iOS Simulator,name=iPad Air 11-inch (M2),OS=18.1" \
            -resultBundlePath TestResults.xcresult
      - uses: slidoapp/[email protected]
        with:
          path: TestResults.xcresult
        if: success() || failure()

I get this log:

Run slidoapp/[email protected]
Creating artifact Xcode test results (TestResults.xcresult)
Uploading artifact Xcode test results (TestResults.xcresult)
Artifact name is valid!
Root directory input is valid!
Beginning upload of artifact content to blob storage
Uploaded bytes 8388608
Uploaded bytes [16](https://github.com/<REDACTED>/pull/4/checks#step:9:17)777216
Uploaded bytes 25165824
Uploaded bytes 33554432
Uploaded bytes 41943040
Uploaded bytes 50331648
Uploaded bytes 53585077
Finished uploading artifact content to blob storage!
SHA256 hash of uploaded artifact zip is 6c8f92d98e8f10526f8632598cfca5dc0928a66ad53fbc4639e2be93596a5e1e
Finalizing artifact upload
Artifact Xcode test results (TestResults.xcresult).zip successfully finalized. Artifact ID 22686[20](https://github.com/<REDACTED>/pull/4/checks#step:9:21)691

The HTML is working fine!

But I get this artifact output:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants