cleanup transients in option THEATER_TRANSIENTS_OPTION #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to: remove nonexisting transients from transient list (option THEATER_TRANSIENTS_OPTION).
Steps to reproduce:
For long running sites this leads to a huge amount of entries in option theater_transient_keys.
Each of them is reset again and again on many actions in wp-admin.
This leads to really slow backend pages.
About the change:
wordpress delete_transient() returns false if transient does not exist (anymore).
This is not an error condition. So removing the transient key from theater_transient_keys should always happen.