When using Slint via FetchContent, don't print a message on every re-configure #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Oct 23, 2023
…configure Require CMake 3.24 to intregate CMake FetchContent and find_package, according to https://cmake.org/cmake/help/latest/guide/using-dependencies/index.html#fetchcontent-and-find-package-integration This way FetchContent_MakeAvailable will first try to call find_package(Slint) and if that fails then fall back to building via FetchContent. Fixes #16
tronical
force-pushed
the
simon/integrate-fetchcontent-find-package
branch
from
9c8f997 to
1182fee
Compare
|
Maybe you want to use Edit: Never mind, this is incompatible with |
ogoffart
reviewed
Oct 23, 2023
| # `release/1.0` will auto-upgrade to the latest Slint >= 1.0.0 and < 1.1.0 | ||
| GIT_TAG release/1 | ||
| SOURCE_SUBDIR api/cpp | ||
| FIND_PACKAGE_ARGS NAMES Slint |
There was a problem hiding this comment.
I think NAMES Slint is actually not deeded there since that's the same name as the first arg of FetchContent_Declare
|
I'll defer this, as what we have does work after all and doesn't require a newer cmake. |
|
Edit: Keeping it open so that we won't forget about it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require CMake 2.4 to intregate CMake FetchContent and find_package, according to https://cmake.org/cmake/help/latest/guide/using-dependencies/index.html#fetchcontent-and-find-package-integration
This way FetchContent_MakeAvailable will first try to call find_package(Slint) and if that fails then fall back to building via FetchContent.
Fixes #16