-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translations MVP #2662
translations MVP #2662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful start! A few brief comments. Let me know when you'd like get detailed reviews.
458ae64
to
77f16be
Compare
Just pitching in here to mention that gettext should not be forced/the only option. Fluent is considered to be better in many aspects and should be supported too. |
@medhefgo totally, we don't want to force gettext. |
Well, you can use message IDs in gettext too... Considering that, I guess it would be better to expose fluent as a separate function/macro ( |
This commit just do the parsing of the @tr macro.
0267079
to
712ecb0
Compare
For rust, it uses the crate name, for others, it needs to be passed in the comment line
728ed10
to
41a7fa9
Compare
It is too fragile otherwise
41a7fa9
to
3af3b58
Compare
This allow to translate a Slint interface using a
@tr(".....")
expressionTODO
@tr()
@tr()
to disambiguate