Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5565 #6997

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Fix #5565 #6997

merged 1 commit into from
Dec 7, 2024

Conversation

teknalb
Copy link
Contributor

@teknalb teknalb commented Dec 4, 2024

Fix/workaround for #5565

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


optimus seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

This looks good to me.

(Note that this might be conflicting with #6675 it if it merged.)

@teknalb
Copy link
Contributor Author

teknalb commented Dec 4, 2024

Thanks, this should've been in winit long ago, at least it doesn't conflict with it when they fix it.
Maybe #6675 should remove this if merged and contradicts this but I think non-resizable window should still not enable the maximize button :)

@teknalb
Copy link
Contributor Author

teknalb commented Dec 4, 2024

Oh, I see that I have dummy user (optimus) attached to this commit, do I need submit a new commit/pull request using only my github user or this will do?

@ogoffart
Copy link
Member

ogoffart commented Dec 4, 2024

This will do.

@ogoffart ogoffart merged commit 0f72791 into slint-ui:master Dec 7, 2024
36 of 37 checks passed
@teknalb teknalb deleted the fix-maximize-button branch December 8, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants