Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable partial rendering with Skia's software renderer by default #7504

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Enable partial rendering with Skia's software renderer by default #7504

merged 1 commit into from
Jan 30, 2025

Conversation

tronical
Copy link
Member

No description provided.

@tronical tronical requested a review from ogoffart January 30, 2025 20:59
@tronical tronical mentioned this pull request Jan 30, 2025
Closed
4 tasks
ogoffart
ogoffart approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you wanted to keep it for one version as disabled by default to get feddback on it before enabling it.
But if you feel confident, let's go for it!

@tronical
Copy link
Member Author

Ah sorry, misunderstanding:). I want to learn more about the performance impact for the GPU renderers as it's not clear when/how exactly it helps - beyond the theory. But for software I'm happy :)

@tronical tronical merged commit ac7c2dd into master Jan 30, 2025
37 checks passed
@tronical tronical deleted the simon/skia-sw-partial-default branch January 30, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogoffart ogoffart ogoffart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tronical @ogoffart