Merge pull request #10 from slovensko-digital/bugfix/response-headers

fix for correct url string for atlassian
slovensko-digital · Oct 2, 2023 · bb1751d · bb1751d
2 parents cc77bbd + fc926e2
commit bb1751d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 19 deletions.
diff --git a/application/src/Model/AtlassianIdeaModel.php b/application/src/Model/AtlassianIdeaModel.php
@@ -6,14 +6,14 @@
 
 class AtlassianIdeaModel implements AttlassianIssueModel
 {
-    private string $serviceDeskId;
-    private string $requestTypeId;
-    private string $summary;
-    private string $description;
-    private string $name;
-    private string $surname;
-    private string $email;
-    private string $phone;
+    protected string $serviceDeskId;
+    protected string $requestTypeId;
+    protected string $summary;
+    protected string $description;
+    protected string $name;
+    protected string $surname;
+    protected string $email;
+    protected string $phone;
 
     public function __construct(
         $summary = '',

diff --git a/application/src/Model/AtlassianProblemModel.php b/application/src/Model/AtlassianProblemModel.php
@@ -6,8 +6,7 @@
 
 class AtlassianProblemModel extends AtlassianIdeaModel
 {
-    private string $url;
-    private string $requestTypeId;
+    protected string $url;
 
     public function __construct(
         $summary = '',
@@ -31,15 +30,6 @@ public function __construct(
         $this->url = $url;
     }
 
-    public function fromArray(array $data = []): void
-    {
-        foreach ($data as $key => $value) {
-            if (property_exists($this, $key)) {
-                $this->{$key} = $value;
-            }
-        }
-    }
-
     public function toArray(): array
     {
         $data = parent::toArray();