-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/accessibility fixes #70
Conversation
728e5f0
to
c938273
Compare
c938273
to
67145f3
Compare
To simplify local development
67145f3
to
4d7687b
Compare
@Matej-Hlatky @matejkepes S týmto buildom sa mi deje rovnaká vec, ako som písal aj v druhom PR #72 - pri remote podpísaní zostane nakonci aplikácia v loading stave. V aktuálnej verzii v Google Play sa toto nedeje. Zmenili ste v oboch PR nejakú rovnakú vec, keď je v nich rovnaký problém? |
Jediny commit ktory sme mergli vcera bol tento Predpokladam ze zmena targetSdkVersion za to nemoze, ale zmena autogram_sign 0.4.1 -> 0.4.4 je sus |
Treba checknut verziu z master. |
Nakoniec je to tento commit Ak je to remote signing, tak state je vzdy inital, pri local signing po zavolani saveDocument() sa nastavi success Povodne sa renderoval pri initialState SuccessContent a tu sa to zmenilo |
2525798
to
e6e69ce
Compare
Potvrdzujem, že problém zmizol |
const PresentSignedRemoteDocumentSuccessState(); | ||
|
||
@override | ||
String toString() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tento override uz netreba, nakolko je zdedeny z parent PresentSignedDocumentState
type.
Len tie, co maju daco navyse by to mali overridovat.
@celuchmarek tak mozme mergnut ? |
áno. Mergnem. |
Resolves #52
Resolves #50
Resolves #51
Resolves #49
Resolves #48
Resolves #47
Resolves #46
Resolves #45
Resolves #44
Resolves #43