Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/accessibility fixes #70

Merged
merged 12 commits into from
Nov 17, 2024
Merged

Feature/accessibility fixes #70

merged 12 commits into from
Nov 17, 2024

Conversation

matejkepes
Copy link
Collaborator

@matejkepes matejkepes commented Nov 16, 2024

Resolves #52
Resolves #50
Resolves #51
Resolves #49
Resolves #48
Resolves #47
Resolves #46
Resolves #45
Resolves #44
Resolves #43

@celuchmarek
Copy link
Member

@Matej-Hlatky @matejkepes S týmto buildom sa mi deje rovnaká vec, ako som písal aj v druhom PR #72 - pri remote podpísaní zostane nakonci aplikácia v loading stave. V aktuálnej verzii v Google Play sa toto nedeje. Zmenili ste v oboch PR nejakú rovnakú vec, keď je v nich rovnaký problém?

@matejkepes
Copy link
Collaborator Author

@Matej-Hlatky @matejkepes S týmto buildom sa mi deje rovnaká vec, ako som písal aj v druhom PR #72 - pri remote podpísaní zostane nakonci aplikácia v loading stave. V aktuálnej verzii v Google Play sa toto nedeje. Zmenili ste v oboch PR nejakú rovnakú vec, keď je v nich rovnaký problém?

Jediny commit ktory sme mergli vcera bol tento
cf70cf0

Predpokladam ze zmena targetSdkVersion za to nemoze, ale zmena autogram_sign 0.4.1 -> 0.4.4 je sus

@Matej-Hlatky
Copy link
Contributor

Treba checknut verziu z master.

@matejkepes
Copy link
Collaborator Author

matejkepes commented Nov 17, 2024

Nakoniec je to tento commit

Ak je to remote signing, tak state je vzdy inital, pri local signing po zavolani saveDocument() sa nastavi success
CleanShot 2024-11-17 at 18 30 49@2x

Povodne sa renderoval pri initialState SuccessContent a tu sa to zmenilo
CleanShot 2024-11-17 at 18 30 58@2x

@matejkepes matejkepes force-pushed the feature/accessibility-fixes branch from 2525798 to e6e69ce Compare November 17, 2024 17:53
@celuchmarek
Copy link
Member

Potvrdzujem, že problém zmizol

const PresentSignedRemoteDocumentSuccessState();

@override
String toString() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tento override uz netreba, nakolko je zdedeny z parent PresentSignedDocumentState type.
Len tie, co maju daco navyse by to mali overridovat.

@Matej-Hlatky
Copy link
Contributor

Potvrdzujem, že problém zmizol

@celuchmarek tak mozme mergnut ?

@celuchmarek
Copy link
Member

áno. Mergnem.

@celuchmarek celuchmarek merged commit e8b3fef into main Nov 17, 2024
1 check passed
@Matej-Hlatky Matej-Hlatky deleted the feature/accessibility-fixes branch November 19, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment