Update settings OBO uniqueness validations #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchal
reviewed
Jul 9, 2024
| @@ -27,6 +27,6 @@ def destroy_with_box? | |||
|
|
|||
| def validate_box(box) | |||
| box.errors.add(:settings_obo, :not_allowed) if obo.present? | |||
| box.errors.add(:settings_obo, :invalid) if boxes.where.not(id: box.id).where("settings ->> 'obo' = ?", box.settings_obo).exists? | |||
| box.errors.add(:settings_obo, :invalid) if boxes.where.not(id: box.id).map { |b| b.settings_obo.to_s }.include?(box.settings_obo.to_s) | |||
There was a problem hiding this comment.
Tu som skor za to, ze upravme tu logiku ze prazdny string nedovolime a bude tam vzdy nil lebo akonahle povolime prazdny string tak sa tato podmienka rozlezie aj vsade inde. Musime cistit data najskor ako sa len daju.
# Conflicts: # db/schema.rb
# Conflicts: # db/schema.rb
# Conflicts: # db/schema.rb
jsuchal
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Neviem ci sme rails 7.1 ale toto mi pride ako dobry fix https://edgeapi.rubyonrails.org/classes/ActiveRecord/Normalization.html
Sme 7.1, upravila som trochu @jsuchal |
jsuchal
reviewed
Sep 5, 2024
| class UpdateEmptyStringsBoxesSettingsObo < ActiveRecord::Migration[7.1] | ||
| def up | ||
| Upvs::Box.find_each do |box| | ||
| box.update(settings_obo: (box.settings_obo.present? ? box.settings_obo : nil)) |
There was a problem hiding this comment.
Tu to vies asi urobit aj jednou query co si vypyta prazdny string ale good enough
jsuchal
reviewed
Sep 9, 2024
jsuchal
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tu sa ukazala potreba upravit trochu query kvoli tomu, ze mame rozne pripady, obo moze byt bud nil alebo aj prazdny string a podobne a potom to nezafungovalo. Bud teda takto upravme query alebo mozeme nejako skusit upratat, aby sme tie rozne tvary prazdneho obo odstranili.