Add webhooks in automation rules #455
Conversation
app/models/automation/webhook.rb
Outdated
| def standard_webhook_data(thing) | ||
| if thing.instance_of?(::MessageThread) | ||
| { | ||
| message_thread_id: thing.id | ||
| } | ||
| elsif thing.instance_of?(::Message) | ||
| { | ||
| message_id: thing.id, | ||
| message_thread_id: thing.thread.id | ||
| } | ||
| else | ||
| throw StandardError.new "Unsupported webhook thing object: '#{thing.class.name}'" | ||
| end | ||
| end |
There was a problem hiding this comment.
Tuto chces double dispatch pripadne polymorfiu na urovni response az vo view
There was a problem hiding this comment.
zatiaľ je všetko iba Message, takže som tieto podmienky vyhodil preč
|
@celuchmarek tu este dve veci mozno, co by sme rovno mohli skusit ako test toho ci to funguje dobre:
|
|
|
|
@jsuchal updatol som podľa review a podľa dohody. Idem ešte nejaký test spraviť. |
app/models/automation/webhook.rb
Outdated
|
|
||
| def fire!(message, event, timestamp, downloader: Faraday) | ||
| data = { | ||
| type: "#{message.class.name}.#{event}", |
There was a problem hiding this comment.
Tu by som mozno pridal underscore nech drzime konvencie rails/ruby
There was a problem hiding this comment.
podľa toho štandardu má byť bodka
There was a problem hiding this comment.
to chapem, ale nazov triedy je camelcase a vsetko ostatne je underscore
There was a problem hiding this comment.
jo, už rozumiem. Dal som .underscore
app/components/settings/rules/automation_rules_table_row_component.html.erb
Show resolved
Hide resolved
| EventBus.subscribe_job :message_thread_created, Automation::MessageThreadCreatedJob | ||
| EventBus.subscribe_job :message_created, Automation::MessageCreatedJob |
There was a problem hiding this comment.
toto som si teraz vsimol, potencialne sa moze stat problem ked v queue budu joby ktore nevie odrazu kod spracovat (lebo uz nema ako)
There was a problem hiding this comment.
jo, nasadíme tak, aby tam neboli.
There was a problem hiding this comment.
Zvykne sa to robit na 2 fazy, naprv nasadis nove, potom ked dobehnu joby, tak nasadis fix co vyhodi joby.
app/lib/event_bus.rb
Outdated
| EventBus.subscribe_job :message_thread_created, Automation::MessageThreadCreatedJob | ||
| EventBus.subscribe_job :message_created, Automation::MessageCreatedJob | ||
| [:message_thread_created, :message_created, :message_draft_submitted].each do |event| | ||
| EventBus.subscribe_job event, Automation::EventTriggeredJob |
There was a problem hiding this comment.
Ked uz robime toto, tak to nazvime asi podla toho co to aj robi Automation::ApplyRulesForEventJob
|
@celuchmarek swagger nejaky a/alebo pouzivatelsku prirucku netreba upravit? |
|
@jsuchal pridal som do swaggeru. Chceme aj do tej PDF dokumentácie? |
| queue_as :automation | ||
| retry_on StandardError, wait: :polynomially_longer, attempts: 10 | ||
|
|
||
| def perform(webhook, thing, event, timestamp) |
There was a problem hiding this comment.
tu len poznamka bokom, ze toto je primitive obsession a vlastne by v evente mal byt ten thing aj timestamp.
There was a problem hiding this comment.
Ale chapem, ze nechces vyrabat serializer/deserializer kvoli tomu
Testy dorobím, naprjv ale chcem vedieť, či je to dobre takto. V podstate som do Automation rules pridal ďalšie triggery z EventBus (message_thread_changed, message_thread_created, message_updated).
Tie webhooky vedia byť prázdny POST na zadanú URL alebo obsahujú body podľa standard-webhooks. T.j. napr:
{ "type":"MessageThread.message_thread_changed", "timestamp":"2024-07-19T10:32:49.129+02:00", "data": { "message_thread_id": 251 } } { "type":"Message.message_created", "timestamp":"2024-07-19T10:44:04.224+02:00", "data": { "message_id": 725, "message_thread_id": 251 } }Autorizáciu webhookov som zatiaľ tiež neriešil, ale IMHO to zatiaľ netreba. Ale je to %lahké dorobiť - do nejakého headera pridáme podpis, prípadne jwt.