Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add env variable for database port #460

Conversation

xhyrom
Copy link
Contributor

@xhyrom xhyrom commented Jul 24, 2024

Je to minimálna zmena ale celkom užitočná, napr. keď databázu mám niekde mimo (nechcem si spúšťať celú postgre na svojom kompe a mám ju v lokálnej sieti). Samozrejme, dá sa to meniť a nepushovať, ale to by bolo otravné.

@jsuchal
Copy link
Member

jsuchal commented Jul 25, 2024

@xhyrom uzitocne to asi je, ale zaujala ma ta vec, ze "nechces postgres na svojom kompe" - normalne si pusti docker image a vies postgres zapinat/vypinat a nijako vela pamate to nezerie (na vyvoj). cize uplne tomuto nerozumiem. vies vysvetlit?

@xhyrom
Copy link
Contributor Author

xhyrom commented Jul 25, 2024

Hej jasné, môžem použiť docker ale nakoniec som si to dal proste na svoj druhý starý ntb kde mi bežia nejaké blbosti a mám tam docker kontainery a portainer. S dockerom by samozrejme problém nebol ale toto bolo rýchlejšie lebo som tam už jednu mal 😅

.env Outdated Show resolved Hide resolved
@xhyrom
Copy link
Contributor Author

xhyrom commented Oct 12, 2024

cc, review @luciajanikova

@luciajanikova luciajanikova requested a review from jsuchal October 15, 2024 12:20
@jsuchal
Copy link
Member

jsuchal commented Oct 15, 2024

@celuchmarek nerozbije toto deploy ak tam nebude toto uvedene v env?

@celuchmarek
Copy link
Member

@jsuchal v pohode. Tie ostatné env tiež nie sú pri builde nastavené, nijako to nesúvisí. Skúsil som docker build a prešlo.

@luciajanikova
Copy link
Member

Okay, tak mergujem.

@luciajanikova luciajanikova merged commit 5307109 into slovensko-digital:main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants