GO-128 Download messages from FS #483

luciajanikova · 2024-10-22T13:29:20Z

Odoslane spravy maju "zlozenu" vizualizaciu: Informacie o podani (custom vizualizacia podla FS portalu) + vizualizacia samotneho vyplneneho formulara. Je to predelene vodorovnou ciarou.
Prijate spravy maju iba custom vizualizaciu podla FS portalu.
Ponukame aj moznost stiahnutia akejkolvek spravy v PDF formate: HTML vizualizacia z GO sa ulozi do PDF. Takze obsah PDF je presne taky isty ako to, co pouzivatel vidi v GO (ziadne transformacie).
Export spravy klasicky: originaly + ku kazdemu tazko citatelnemu (asice, XML) objektu sa vygeneruje PDF.

Video ukazka na mojej FS schranke importovanej do GO:

fs_go.mp4

app/jobs/fs/download_received_message_job.rb

app/models/concerns/pdf_visualization_operations.rb

jsuchal · 2024-10-22T18:12:49Z

app/models/fs/message.rb

+        delivered_at: message.delivered_at
+      )
+
+      associated_message_draft.destroy if associated_message_draft


Nebude tu rovnaky problem so stracajucimi sa tagmi?

Bude, myslim na to, ale logiku toho by som vyladila v tom otvorenom PR najprv a potom to lahko preklopim aj sem. Nech to neriesime teraz na dvoch miestach.

jsuchal · 2024-10-22T18:13:42Z

app/models/fs/message.rb

+  end
+
+  def self.collapsed?
+    # TODO urcit podmienky: odoslana sprava s potvrdenkou by mohla byt collapsed


Kedze ta dorucenka je extremne dolezita pre nich, tak skor prave naopak.

Je to tu zle naformulovane, mala som na mysli, ze podanie by mohlo byt collapsed v pripade, ze uz prisla dorucenka. Toto su zatial rychle komentare v ramci draftu, doladim este.

app/models/message.rb

jsuchal · 2024-10-22T18:14:56Z

app/views/fs/messages/_delivery_report.html.erb

+  }
+</style>
+
+<table class="min-w-full divide-y divide-gray-300">


Mas screen ako toto vyzera?

a detaily su ukazane vo videu, ktore je prilozene v popise.

jsuchal · 2024-10-22T18:15:35Z

app/views/fs/messages/_submission.html.erb

+      <td>
+        <b>
+          <time class="md:hidden" datetime="<%= message.delivered_at %>">
+            <%= ApplicationController.helpers.nice_datetime_with_time(message.delivered_at, keep_year: true) %>


Toto sa neda volat priamo cez nice_datetime_with_time ?

Nie, lebo to nevolame z controllera, tak nie su bezne dostupne veci vo view k dispozicii

luciajanikova · 2024-10-23T12:02:21Z

app/helpers/fs/message_helper.rb

+  def self.build_html_visualization(message)
+    return [ActionController::Base.new.render_to_string('fs/messages/_submission', layout: false, locals: { message: message }), build_html_visualization_from_form(message)].compact.join('<hr>') if message.outbox?
+
+    # TODO: Vieme aj lepsie identifikovat? Nejake dalsie typy v tejto kategorii neexistuju?


Toto tu je otvorena vec. FS API v response vracia aj message_type, da sa identifikovat aj podla toho (ale tiez to je trochu len take hadanie, ked nemame nejaku dokumentaciu k tomu). Nevieme ako casto sa mozu zmenit bud tieto nazvy alebo message_type.
Samotna dorucenka si myslim, ze problem nie je (tam by som sa spolahla aj na message_type), ale tieto negativne verzie su narocnejsie. Nevieme ani kolko typov existuje.

luciajanikova · 2024-10-23T12:10:55Z

app/views/fs/messages/_delivery_report.html.erb

+  <tr>
+    <th>Dôvod zmeny stavu podania:</th>
+    <td>
+      <b><!--TODO tato informacia z API neprichadza, nachadza sa to vsak vo vnutri, v XML (vyplnene to je napr. v pripade odmietnuteho podania). Parsovat/neparsovat, kde?--></b>


Tiez otvorena vec. Napr. v pripade nepodarenych podani, ktore sme skusali v zaciatkoch implementacie sme vdaka tomuto vycitali, kde bol problem v podani. Chyba bola uvedena v tomto policku na portali.
Je to vsak podla vsetkeho vyparsovane priamo z XML obsahu.

Toto tiez prosim @celuchmarek keby sa skusis este posprtat v tom, ci to nahodou nevieme ziskat jednoducho v response alebo to treba naozaj len parsovat.

písali sme na Slacku

luciajanikova · 2024-10-23T12:11:58Z

app/views/fs/messages/_delivery_report.html.erb

+  <tr>
+    <th>Obdobie:</th>
+    <td>
+      <b><!--TODO zistit co tu byva vyplnene (zatial sme videli iba prazdne)--></b>


Toto asi bude potrebne overit s nejakym vacsim FS userom, nech zistime, co tu zvykne byt vyplnene.

@celuchmarek Jano spominal, ze k tomuto by sme mozno vedeli vycitat nejake info aj z XSDciek k response/WSDL. Vedel by si skusit popatrat?

V response toho môže byť viac. Všetky fieldy sú tam optional. Teraz máme v tom api iba tie, čo som dostával pri volaní, viem tam ale pomerne ľahko dohodiť všetky. Napr. obdobie je v popise API, takže pridáme do FS API a zistíme, či to aj z FS reálne vracia.

app/models/fs/message.rb

luciajanikova · 2024-10-23T16:15:06Z

Otestovane na podani & spatvzati podania.

… the app)

luciajanikova · 2024-10-28T15:44:03Z

Tu este je potrebne upravit implementaciu spracovania stiahnutej spravy podla zmien v #477.

# Conflicts: # app/models/message.rb # db/schema.rb

…Rule for adding tag 'S potvrdenkou'

luciajanikova · 2024-11-12T09:19:25Z

Spravy sa oznacuju za precitane, len tie, ktore stiahneme. Takze get na cely zoznam sprav v priecinku neoznacuje nic za precitane.
Tym padom to nie je kriticke. @jsuchal

luciajanikova · 2024-11-12T12:04:10Z

Za mna sme nevyhnutne blockery, ktore sme identifikovali odstranili. Co zostava otvorene:

Lepsie pomenovavanie potvrdeniek pri stahovani (teraz to je vzdy DeliveryReport)

Oznacovanie vlakien s potvrdenkou tagom vieme vyriesit pomocou automation. Rovnako je mozne nastavit automation tak, aby bol pridany tag na vlakno po stiahnuti potvrdenky. (aby bolo mozne filtrovat vlakna, kde uz potvrdenka prisla a tiez vlakna, v ktorych uz boli potrebne dokumenty stiahnute lokalne)

Problem este mame s nasadenim. Ten gem Grover, ktory pouzivame na generovanie PDFiek vyzera byt narocnejsie pouzit.
https://pptr.dev/troubleshooting#chrome-doesnt-launch-on-linux
https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md
Pri tom by som asi potrebovala pomoc od Mareka, ak teda chceme zostat pri tomto gem. @jsuchal

…s downloaded

app/controllers/message_objects_controller.rb

jsuchal · 2024-11-12T14:25:15Z

Problem este mame s nasadenim. Ten gem Grover, ktory pouzivame na generovanie PDFiek vyzera byt narocnejsie pouzit.

@celuchmarek vyzera, ze tam treba dost vela libs ale teda asi staci skusit dockerfile obohatit

celuchmarek · 2024-11-12T15:31:00Z

@luciajanikova @jsuchal ten Grover s Chromium som rozbehal pre Docker container na x86 archhitektúre (čiže aj náš cluster). Skúšal som na virtuálke, čo mám doma - vyrobilo mi to PDF z html stránky. Na Macu s arm64 mi to v dockeri nefunguje, ale to asi nevadí. Ten jeden pridaný ENV som už nastavil aj na gitlabe. Povedzte, či môže byť.

jsuchal · 2024-11-12T15:40:05Z

@luciajanikova tebe ten grover ide na macu?

luciajanikova · 2024-11-12T16:33:11Z

@luciajanikova tebe ten grover ide na macu?

ano, ale mimo dockera

luciajanikova · 2024-11-12T23:04:54Z

Dockerfile

@@ -1,7 +1,8 @@
 FROM ruby:3.3.0

 # Install packages
-RUN apt-get update && apt-get install -y build-essential nodejs libpq-dev npm fop=1:2.* libsaxon-java libsaxonb-java chromium
+RUN apt-get update && apt-get install -y build-essential nodejs libpq-dev npm fop=1:2.* libsaxon-java libsaxonb-java chromium \
+    && apt-get -y install libx11-xcb1 libxcomposite1 libasound2 libatk1.0-0 libatk-bridge2.0-0 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libglib2.0-0 libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6


Este som sem dolozila podla https://ploi.io/documentation/server/how-to-install-puppeteer-on-ubuntu, nestacilo len chromium. Pozri prosim @celuchmarek, ci sme s tym ok.
Uz je to co potrebujeme funkcne takto.

Toto moze celkom nafuknut ten image ale teda skusme co to spravi.

čo už, aj tak má ten image už cez 3GB, takže už je to jedno.

luciajanikova · 2024-11-14T15:45:20Z

app/jobs/fs/sync_all_boxes_job.rb

+      # TODO ponastavovat v BetterUptime
+      BetterUptimeApi.ping_heartbeat('FS_SYNC')


@celuchmarek pridame heartbeat? Mozem skusit aj ja ponastavovat, ale povedz, aby som ti nebabrala do toho pripadne.

Jj, môžeš pridať a nastaviť. Todo comment vyhoď, to nastavíš hneď.

luciajanikova added 14 commits October 15, 2024 12:23

Draft downloading sent FS message

bb0a0a0

Move creating message with thread to Fs::Message

0ac9aa8

Save correlation_id to Fs::MessageDraft

ce6ab5b

Update downloading FS sent messages & Add downloading received messages

95e9b4e

Remove format_html_visualization method

154ee47

Update Fs::Api

6e6ac84

Small syntax updates

823fe35

Draft custom FS visualizations

0dbe7f0

Update visualizations

41e10c9

Create PDF from message HTML visualization

47899d5

Update FS HTML visualizations templates

fdbe251

Update datetime operations & FS API response updates

a32b402

Add submission_type_identifier attribute to Fs::Form

8ac7511

Use paging when requesting FS messages

2f935b6

jsuchal reviewed Oct 22, 2024

View reviewed changes

luciajanikova added 5 commits October 23, 2024 10:21

Draft Fs boxes sync

351dce0

Update brakeman ignore

fd14363

Update checks in download messages jobs

be51628

Small syntax updates

e19f6e4

Update sync FS box jobs

1b81b73

luciajanikova commented Oct 23, 2024

View reviewed changes

luciajanikova added 3 commits October 23, 2024 14:16

Formatting updates

7d2fd3e

Update Fs::MessageDraft visualizations

0747cc4

Add display_url to generated PDF

6840c4f

luciajanikova marked this pull request as ready for review October 23, 2024 13:45

luciajanikova requested a review from jsuchal October 23, 2024 13:45

luciajanikova commented Oct 23, 2024

View reviewed changes

app/models/fs/message.rb Show resolved Hide resolved

Small fixes after PROD testing

50ca8c5

luciajanikova added 4 commits October 24, 2024 14:27

Update Fs::DownloadSentMessageJob

6dbbe2c

Merge branch 'main' into GO-128/download_messages_from_fs

58bfcc2

Schedule Fs::FetchFormsJob in latest migration

63ce7b3

Add style to Fs::Messages HTML visualizations (to use same font as in…

a5167d9

… the app)

luciajanikova added 5 commits October 29, 2024 10:04

Merge branch 'main' into GO-128/download_messages_from_fs

1c38460

# Conflicts: # app/models/message.rb # db/schema.rb

Make download jobs fail if any error

266ffa0

Send uuids to FS API when submitting

84f1650

Copy tags to downloaded FS outbox message from draft

dcfd011

Update Automation::Condition in order to be able to create Automation…

5d9e89d

…Rule for adding tag 'S potvrdenkou'

luciajanikova added 2 commits November 12, 2024 10:36

Add missing fixtures

5d135b3

Add missing fixtures 2

7307fae

Update automation to be able to add tag to thread after form object i…

9de9135

…s downloaded

jsuchal reviewed Nov 12, 2024

View reviewed changes

app/controllers/message_objects_controller.rb Outdated Show resolved Hide resolved

make grover work in docker container

16dc11c

Update download message object event

6a97f21

jsuchal approved these changes Nov 12, 2024

View reviewed changes

Try to update Dockerfile

8474ba5

luciajanikova commented Nov 12, 2024

View reviewed changes

luciajanikova merged commit 4f81339 into main Nov 13, 2024
3 checks passed

luciajanikova deleted the GO-128/download_messages_from_fs branch November 13, 2024 07:24

luciajanikova commented Nov 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GO-128 Download messages from FS #483

GO-128 Download messages from FS #483

luciajanikova commented Oct 22, 2024 •

edited

Loading

jsuchal Oct 22, 2024

luciajanikova Oct 23, 2024

jsuchal Oct 22, 2024

luciajanikova Oct 23, 2024

jsuchal Oct 22, 2024

luciajanikova Oct 23, 2024 •

edited

Loading

jsuchal Oct 22, 2024

luciajanikova Oct 23, 2024

luciajanikova Oct 23, 2024 •

edited

Loading

luciajanikova Oct 23, 2024

luciajanikova Oct 24, 2024

celuchmarek Oct 24, 2024

luciajanikova Oct 23, 2024

luciajanikova Oct 24, 2024

celuchmarek Oct 24, 2024

luciajanikova commented Oct 23, 2024

luciajanikova commented Oct 28, 2024

luciajanikova commented Nov 12, 2024

luciajanikova commented Nov 12, 2024 •

edited

Loading

jsuchal commented Nov 12, 2024

celuchmarek commented Nov 12, 2024 •

edited

Loading

jsuchal commented Nov 12, 2024

luciajanikova commented Nov 12, 2024 •

edited

Loading

luciajanikova Nov 12, 2024

jsuchal Nov 13, 2024

celuchmarek Nov 13, 2024

luciajanikova Nov 14, 2024

celuchmarek Nov 14, 2024

		# TODO ponastavovat v BetterUptime
		BetterUptimeApi.ping_heartbeat('FS_SYNC')

GO-128 Download messages from FS #483

GO-128 Download messages from FS #483

Conversation

luciajanikova commented Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luciajanikova Oct 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luciajanikova Oct 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luciajanikova commented Oct 23, 2024

luciajanikova commented Oct 28, 2024

luciajanikova commented Nov 12, 2024

luciajanikova commented Nov 12, 2024 • edited Loading

jsuchal commented Nov 12, 2024

celuchmarek commented Nov 12, 2024 • edited Loading

jsuchal commented Nov 12, 2024

luciajanikova commented Nov 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luciajanikova commented Oct 22, 2024 •

edited

Loading

luciajanikova Oct 23, 2024 •

edited

Loading

luciajanikova Oct 23, 2024 •

edited

Loading

luciajanikova commented Nov 12, 2024 •

edited

Loading

celuchmarek commented Nov 12, 2024 •

edited

Loading

luciajanikova commented Nov 12, 2024 •

edited

Loading