GO-141 Do not inform user about message_draft diff in validations #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchal
reviewed
Nov 14, 2024
| } | ||
| message_draft.add_cascading_tag(message_draft.tenant.submission_error_tag) | ||
|
|
||
| diff = response[:body]['problems']&.select { |problem| problem['level'] == 'diff' } |
There was a problem hiding this comment.
nechceme si ten diff odlozit do metadat radsej ako do logu?
There was a problem hiding this comment.
mozeme, ale drafty sa budu mazat po submite & stiahnuti plnohodnotnej spravy
There was a problem hiding this comment.
aha, dobra poznamka. Nemali by sme si tie warningy a metadata skopirovat tiez (tak podobne ako tagy). Asi by som cakal, ze ked tam bol nejaky warning tak nechcem aby zmizol.
jsuchal
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kedze nemame zanalyzovane, co vsetko sa v diffe moze vyskytovat a ako presne to chceme pouzivatelovi komunikovat, tak zatial by sme si to iba logovali a pouzivatelovi nic o diffe nehovorili.