Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 244/blank results visualization #504

Merged

Conversation

crutch
Copy link
Contributor

@crutch crutch commented Nov 16, 2024

  1. Rebased against main (was not able to run it due to database changes)
  2. Fixed not being able to add filters from an empty state

@crutch crutch requested a review from a team as a code owner November 16, 2024 16:28
@crutch
Copy link
Contributor Author

crutch commented Nov 16, 2024

image image image image image

@jsuchal
Copy link
Member

jsuchal commented Nov 16, 2024

@crutch tu vidim este mrte konfliktov

@crutch crutch changed the base branch from GO-244/blank_results_visualization to main November 16, 2024 19:51
@crutch
Copy link
Contributor Author

crutch commented Nov 16, 2024

Aha, moja blbost. Zmenil som ten PR tak, aby bol voci main branch, nie voci tej povodnej blank results branch. Tu som musel rebasovat.

@jsuchal jsuchal merged commit a777ed4 into slovensko-digital:main Nov 18, 2024
3 checks passed
@luciajanikova
Copy link
Member

@jsuchal nechceli sme sem zahrnut este aj notifikacie?

@jsuchal
Copy link
Member

jsuchal commented Nov 18, 2024

@luciajanikova dobra poznamka, pridajme issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants