GO-168 Make MessageDraft metadata POSP params optional #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciajanikova
commented
Dec 18, 2024
Comment on lines
+115
to
+117
| ::Upvs::Form.find_by( | ||
| identifier: all_metadata['message_type'] | ||
| ) |
There was a problem hiding this comment.
Implementacia je funkcna kompletne - HTML vizualizacia, PDF vizualizacie, XSD validacie a vsetko ostatne. ALE s formularom to je iba docasny hotfix, nie stabilne riesenie.
Tieto ORSR formulare nie su v MEF a celkovo su o dost ine ako bezne UPVS formulare. Z beznych UPVS formularov vieme z XML obsahu podania jednoducho vyparsovat posp_id, posp_version a na zaklade toho jednoznacne vieme identifikovat o aky formular sa jedna a dotiahnut spravne XSD, XSLT.
Pri tychto ORSR to tak nie je, takze hotfix je:
- XSD, XSLT hodime teraz jednorazovo do DB,
Upvs::Forma teda jeho XSD, XSLT budeme s draftom matchovat iba na zaklademessage_type-> co znamena, ze neberieme vobec do uvahy verziu formulara.
Myslim, ze docasne takto prezijeme a potom doladime, nakolko treba vyriesit:
- Ako identifikovat z XML obsahu o aky typ formulara sa jedna (s know how by mohol pomoct autogram kod),
- Odkial dotahovat XSD, XSLT - chceli by sme to idealne vsetko tahat z nasho S3 uloziska.
jsuchal
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.