Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #109 #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue #109 #111

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 14, 2019

Komponent pre aktualnu temu.

@julius-retzer
Copy link

@MartinTuroci Ako si na tom s tymto? Planujes pokracovat? Ked nie a preberiem to po tebe, das mi k tomu nejake intro, ze co je spravene a co treba spravit?

@jsuchal
Copy link
Member

jsuchal commented Oct 24, 2019

@Wormyy neviem ci sme sa uplne pochopili s @MartinTuroci . Mam na mysli tento global header tuto

image

pripadne nieco ako popular tu

image

Asi ma vacsi zmysel teraz to prve.

@ghost
Copy link
Author

ghost commented Oct 24, 2019

@Wormyy tento PR caka na review a merge :) @jsuchal komponent je rovnaky ako je popisany v #109. Nastala nejaka zmena?

@jsuchal
Copy link
Member

jsuchal commented Oct 24, 2019

@MartinTuroci pozeram ze nastala lebo na gov.uk to uz nie je a tento novy banner viac sedi na oznamy, hento cervene asi fakt bolo iba nieco docasne na gov.uk, hm...

@julius-retzer
Copy link

Aha, no som trochu strateny, asi niekde nastala miskomunikacia :D @HanaBene mi napisala, ze nieco na tomto PR treba dokoncit.

Inac, navrhol by som nazvat to current topic, actual theme sa mi nezda ako spravny preklad.

@jsuchal
Copy link
Member

jsuchal commented Oct 25, 2019

@Wormyy ty mozes zacat robit ten banner co som ja poslal.

@HanaBene
Copy link
Collaborator

HanaBene commented Oct 28, 2019

@jsuchal mozes prosim pozriet, co treba dorobit ku komponentu Aktualna tema, co robil @MartinTuroci, aby bol ready to go - tzn. v Admine zapnutelny, definovany nadpis, podnadpis, text buttonu. Tu je issue v Ruby repe slovensko-digital/navody.digital#263

@Wormyy tento komponent je teda zastreseny Martinom, spravim druhu issue pre komponent Message -> vizual poslal jano vyssie. Nemalo by to byt upozornenie, cervene, vyrazne, ale skor jemnejsie.
EDIT: #112 issue tu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants