Upstream sync #127
Merged
Upstream sync #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a href by itsef results in an invisible link (no visible text). Passing text by itself results in a link with no href. Therefore, mark the footer meta.items.text and meta.items.href as required.
The way the previous tests were structured seemed to test for the presence of at least one single object within the component options with the required attributes, instead of all options having the correct attributes. The same was happening for the fixtures file. This meant that one missing `required` attribute in a component yaml file would not cause the test to fail. This commit tests for the presence of the required attributes by looping through each option/fixture. It also fixes one typo picked up by these new tests.
…examples Update required options for components
Enable custom inputmode for date input component
Correctly label the conditionally revealed email address field ‘email address’ rather than ‘mobile phone number’ in the conditional reveals examples for checkboxes and radios
Bumps [marked](https://github.com/markedjs/marked) from 1.1.1 to 2.0.0. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v1.1.1...v2.0.0) Signed-off-by: dependabot[bot] <[email protected]>
…n/marked-2.0.0 Bump marked from 1.1.1 to 2.0.0
`ChildNode.remove` is not supported in IE11, so use the hidden attribute like we do with the client side example.
Fix Frontend CHANGELOG punctuation
…e-ie11 Fix client-side cookie banner hide button in IE 11
The deprecation warning for the `iff` function currently appears in the middle of the test output:
```
PASS src/govuk/objects/objects.test.js
PASS src/govuk/overrides/overrides.test.js
PASS src/govuk/core/core.test.js
WARNING: The `iff` function will be removed in a future release, use `if($condition, $if-true, null);` instead.
on line 15 of src/govuk/tools/_iff.scss, in function `iff`
from line 5 of stdin
WARNING: The `iff` function will be removed in a future release, use `if($condition, $if-true, null);` instead.
on line 15 of src/govuk/tools/_iff.scss, in function `iff`
from line 5 of stdin
PASS src/govuk/tools/iff.test.js
```
Silence it by mocking the @warn function in Sass render calls from its tests, and add a new test for the deprecation warning.
This it consistent with the approach used for the import deprecation warnings from the overrides and core layers.
…rning Silence deprecation warning for iff in tests and add test
New CSS to change the cursor to pointer when hovered over, as per any other link, including other links in the header. An edge case perhaps because this will presumably mostly be for mobile, but for desktops with a narrow window, or heavily zoomed in, a pointer cursor will be consistent with other links.
Use pointer cursor for 'Menu' button in header
…-vertical-alignment Improve vertical alignment of phase banner tag on mobile devices
This pull request improves vertical alignment of phase banner tag on mobile devices
Adding pull request alphagov#2132 to change log
…rmat Replace e.g. in Character count macros
|
@allie47 toto je slusna robota, skusal som to vcera lokalne ale zatial sa mi to nejako nedari zbuildit tak, aby to zafungovalo. Ty vies vyrobit package aspon lokalne? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124
Presla/preklikala/porovnala som, ak sa nepletiem, vsetky custom examples aj komponenty, taktiez aj vacsinu govuk komponentov. Testy tak ako som ich poopravovala vyzeraju bezat v pohode, stylelint je pofixovany, build:package tiez.
Dizajnove rozdiely, ktore som nechala tak, ako su v najnovsom govuk:
Dizajnove rozdiely, ktore som upravila, aby boli podobne povodnemu designu:
Dalsie relevantne zmeny (ktore mozu vyzadovat daky task/issue creation do buducna):
test:dependenciessom vyhodila znpm test(niekto bude musiet pofixovat tienpm ERR! extraneousnech na tom nepadaju testy komplet)replace-diacritcs.jsaslovak-municipalities.js, kedze cely koncept vyzera, ze by sa mu nepacil (nepouzite premenne, plus municipalities by narastli do objemu kedze uz vyzaduje medzery vsade)after-build-package.test.js, ktory overuje "should contain the expected files" som odkomentovala, kedze ho momentalne nemam ako overit, ci je korektne upraveny (pri developmente na Windowse nefici)Notes: Neviem, ci to tak bol aj predtym, ale vyzera to ze viacere veci tam su zavisle na tom, ze sa nedevelopi na windowse (pozna sa to napr na
jest-puppeteer.configfile a setovani PORTu, na niektorych testoch, atd)