forked from alphagov/govuk-frontend
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync upstream 2022 #130
Open
jsuchal
wants to merge
6,022
commits into
slovensko-digital:master
Choose a base branch
from
alphagov:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sync upstream 2022 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`checkSupport` of `GOVUKFrontend` can be overloaded by classes that extend it. Added tests for `createAll` when `checkSupport` has been overloaded.
It was introduced in #5328, but we'll be encouraging people to override `checkSupport` and throw their own errors. This means they don't need to override `isSupported` specifically, especially as this didn't let them customise the error message when the component was not supported
`ElementError` now accepts a `component` in config. This means the component name can be accessed from the supplied `component`. `formatErrorMessage` helper function added as it is a common string format for error messages that can be used by other errors going forward.
Components now use new `ElementError` format, they provide the class which called the error rather than the string of the component name. The tests have been updated with this change.
Co-authored-by: seaemsi <[email protected]>
Co-authored-by: seaemsi <[email protected]>
Co-authored-by: seaemsi <[email protected]>
Co-authored-by: seaemsi <[email protected]>
Remove the need for components to have a `defaults` static property, as it's really an internal convention which is a lot to ask from outside components.
…alidate-8.27.0 Bump html-validate from 8.25.1 to 8.27.0
…github/workflows/actions/install-node/actions/cache-4.2.0 Bump actions/cache from 4.1.2 to 4.2.0 in /.github/workflows/actions/install-node
…s-4.21.2 Bump express from 4.21.1 to 4.21.2
…e-lite-1.0.30001687 Bump caniuse-lite from 1.0.30001684 to 1.0.30001687
…github/workflows/actions/build/actions/cache-4.2.0 Bump actions/cache from 4.1.2 to 4.2.0 in /.github/workflows/actions/build
…ons/cache-4.2.0 Bump actions/cache from 4.1.2 to 4.2.0
…bd9cfccfcc Bump the percy group with 2 updates
Bumps the types group with 1 update: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node). Updates `@types/node` from 22.9.3 to 22.10.1 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: types ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the percy group with 2 updates: [@percy/core](https://github.com/percy/cli/tree/HEAD/packages/core) and [@percy/cli](https://github.com/percy/cli/tree/HEAD/packages/cli). Updates `@percy/core` from 1.30.4 to 1.30.5 - [Release notes](https://github.com/percy/cli/releases) - [Commits](https://github.com/percy/cli/commits/v1.30.5/packages/core) Updates `@percy/cli` from 1.30.4 to 1.30.5 - [Release notes](https://github.com/percy/cli/releases) - [Commits](https://github.com/percy/cli/commits/v1.30.5/packages/cli) --- updated-dependencies: - dependency-name: "@percy/core" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: percy - dependency-name: "@percy/cli" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: percy ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the types group with 1 update: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node). Updates `@types/node` from 22.10.1 to 22.10.2 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: types ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [caniuse-lite](https://github.com/browserslist/caniuse-lite) from 1.0.30001687 to 1.0.30001689. - [Commits](browserslist/caniuse-lite@1.0.30001687...1.0.30001689) --- updated-dependencies: - dependency-name: caniuse-lite dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sass-loader](https://github.com/webpack-contrib/sass-loader) from 16.0.3 to 16.0.4. - [Release notes](https://github.com/webpack-contrib/sass-loader/releases) - [Changelog](https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/sass-loader@v16.0.3...v16.0.4) --- updated-dependencies: - dependency-name: sass-loader dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 5.1.0 to 5.2.0. - [Release notes](https://github.com/webpack/webpack-dev-server/releases) - [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md) - [Commits](webpack/webpack-dev-server@v5.1.0...v5.2.0) --- updated-dependencies: - dependency-name: webpack-dev-server dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…oader-16.0.4 Bump sass-loader from 16.0.3 to 16.0.4
…e-lite-1.0.30001689 Bump caniuse-lite from 1.0.30001687 to 1.0.30001689
…a3ad68ca8b Bump @types/node from 22.10.1 to 22.10.2 in the types group
…1849ad68f2 Bump the percy group with 2 updates
…k-dev-server-5.2.0 Bump webpack-dev-server from 5.1.0 to 5.2.0
Bumps the lint group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [editorconfig-checker](https://github.com/editorconfig-checker/editorconfig-checker.javascript) | `5.1.8` | `6.0.0` | | [prettier](https://github.com/prettier/prettier) | `3.3.3` | `3.4.2` | | [standard](https://github.com/standard/standard) | `17.1.0` | `17.1.2` | | [stylelint](https://github.com/stylelint/stylelint) | `16.9.0` | `16.11.0` | | [typescript](https://github.com/microsoft/TypeScript) | `5.5.4` | `5.7.2` | Updates `editorconfig-checker` from 5.1.8 to 6.0.0 - [Release notes](https://github.com/editorconfig-checker/editorconfig-checker.javascript/releases) - [Changelog](https://github.com/editorconfig-checker/editorconfig-checker.javascript/blob/master/CHANGELOG-LEGACY.md) - [Commits](editorconfig-checker/editorconfig-checker.javascript@v5.1.8...v6.0.0) Updates `prettier` from 3.3.3 to 3.4.2 - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.3.3...3.4.2) Updates `standard` from 17.1.0 to 17.1.2 - [Release notes](https://github.com/standard/standard/releases) - [Changelog](https://github.com/standard/standard/blob/master/CHANGELOG.md) - [Commits](standard/standard@v17.1.0...v17.1.2) Updates `stylelint` from 16.9.0 to 16.11.0 - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@16.9.0...16.11.0) Updates `typescript` from 5.5.4 to 5.7.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.5.4...v5.7.2) --- updated-dependencies: - dependency-name: editorconfig-checker dependency-type: direct:development update-type: version-update:semver-major dependency-group: lint - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor dependency-group: lint - dependency-name: standard dependency-type: direct:development update-type: version-update:semver-patch dependency-group: lint - dependency-name: stylelint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: lint - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: lint ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the lint group with 1 update in the / directory: [stylelint](https://github.com/stylelint/stylelint). Updates `stylelint` from 16.11.0 to 16.12.0 - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@16.11.0...16.12.0) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: lint ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.26.11 to 0.27.5. - [Release notes](https://github.com/TypeStrong/TypeDoc/releases) - [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md) - [Commits](TypeStrong/typedoc@v0.26.11...v0.27.5) --- updated-dependencies: - dependency-name: typedoc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Fix UMD files overriding existing global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.