-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifiers feature #679
Open
busslina
wants to merge
27
commits into
slovnicki:master
Choose a base branch
from
busslina:notifiers-feature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Notifiers feature #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When BeamPage is BeamPageType.noTransition
Hey @busslina it seems interesting, but it will take me some time to inpect it. |
Yeah, works great but also could be a mess as is not easy for me to integrate others code that I don't know very well. BTW I just started my own routing library. If I achieve something I let you know :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes introduces two new related features:
Pinnacle page: The top level page on a beam stack.
Motivation:
In order to understand this changes I will explain my use case: I have a top level router which handles all the routes and I have three child sibling routers:
Why having those routers? Because I need to stack some floating layers on top of each (header, screen and footer), and these floating layers must survive (live more than) the routes & beams stacks. This is the reason to have the first feature. It's an optional object passed in the page creation (notified on pinnacle page change) that, in my case, can help to customize those floating layers based on the current visible page (pinnacle page).
The second feature is more obvious: To be able to optionally notify every page on every stack state change (E.G. page position in the stack) in a push way instead of the more trickier way of listening router changes and compare url path. This is done by passing an optional notifier in the page creation.