Fix Bug if no creators exists

slub · Jan 15, 2025 · 21c52c2 · 21c52c2
1 parent 2586601
commit 21c52c2
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/Classes/Processing/BibEntryProcessor.php b/Classes/Processing/BibEntryProcessor.php
@@ -91,7 +91,21 @@ public static function buildNestedField(
     {
         return Collection::wrap($fieldConfig)->
             map(function ($field) use ($bibliographyItem) {
-                return self::buildListingEntry($field, $bibliographyItem);
+            $entry = self::buildListingEntry($field, $bibliographyItem);
+
+            // buildListingEntry can return null if no field creators exist
+            if ($entry === null) {
+                // ignore or return empty array ?
+                return []; //
+            }
+
+            if (!is_array($entry)) {
+                throw new \UnexpectedValueException(
+                    'Expected array from buildListingEntry, but got: ' . gettype($entry)
+                );
+            }
+
+            return $entry;
             })->
             flatMap(function (array $item): Collection {
                 //if (is_array($item)) { -> @Thomas do we need this?
@@ -134,7 +148,9 @@ private static function buildListingEntry(array $field, array $bibliographyItem)
             isset($field['field']) &&
             !isset($bibliographyItem[$field['field']]) ||
             isset($field['compound']['field']) &&
-            !isset($bibliographyItem[$field['compound']['field']])
+            !isset($bibliographyItem[$field['compound']['field']]) ||
+            isset($field['compoundArray']['field']) &&
+            !isset($bibliographyItem[$field['compoundArray']['field']])
         ) {
             return null;
         }