Single StringBuilder allocation per find (#1016)

smallrye · Oct 2, 2023 · 97bcfd0 · 97bcfd0
1 parent 7624248
commit 97bcfd0
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/implementation/src/main/java/io/smallrye/config/KeyMap.java b/implementation/src/main/java/io/smallrye/config/KeyMap.java
@@ -178,15 +178,20 @@ public KeyMap<V> findOrAdd(final String path) {
         return findOrAdd(new NameIterator(path));
     }
 
-    public KeyMap<V> findOrAdd(final NameIterator ni) {
+    public KeyMap<V> findOrAdd(final NameIterator path) {
+        return findOrAdd(path, new StringBuilder());
+    }
+
+    KeyMap<V> findOrAdd(final NameIterator ni, final StringBuilder sb) {
         if (!ni.hasNext()) {
             return this;
         }
-        String seg = ni.getNextSegment();
+        String seg = ni.getNextSegment(sb).toString();
         ni.next();
         try {
             KeyMap<V> next = getNext(seg);
-            return next.findOrAdd(ni);
+            sb.setLength(0);
+            return next.findOrAdd(ni, sb);
         } finally {
             ni.previous();
         }