Reimplement handling of environment variables names to improve performance and allocation #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
radcortez
commented
Sep 19, 2023
•
radcortez
commented
- With a dedicated representation that can use equals and hashcode
- With filtering and matching only what is required
radcortez
changed the title
franz1981
reviewed
Sep 19, 2023
implementation/src/main/java/io/smallrye/config/EnvConfigSource.java
Outdated
Show resolved
Hide resolved
franz1981
reviewed
Sep 19, 2023
implementation/src/main/java/io/smallrye/config/EnvConfigSource.java
Outdated
Show resolved
Hide resolved
franz1981
reviewed
Sep 19, 2023
franz1981
reviewed
Sep 19, 2023
…mance and allocation: - With a dedicated representation that can use equals and hashcode - With filtering and matching only what is required
radcortez
force-pushed
the
more-improvements
branch
from
3650fd8 to
60690b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.