Various suggestions #1277
Draft
Various suggestions #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given we are adding quite a lot of elements, there are a lot of chances the maps will have to be resized several times.
The convertProfile() method is called several times and there's no need to create the converter again and again.
It seems counter productive to throw so many NoSuchMethodExceptions for these common uses cases.
This avoids a bunch of allocations, including the allocation of an ObjectCreator for each property. It was kept simple on purpose as a base for discussions. Note that, interestingly enough, my startup actually got a bit slower with this patch which makes little sense... I thought it might be interesting to discuss this line of thoughts anyway.
radcortez
reviewed
Jan 2, 2025
| @@ -67,65 +67,25 @@ private Converters() { | |||
|
|
|||
| static final Converter<ConfigValue> CONFIG_VALUE_CONVERTER = new ConfigValueConverter(); | |||
|
|
|||
| static final Converter<String> STRING_CONVERTER = BuiltInConverter.of(0, newEmptyValueConverter(value -> value)); | |||
There was a problem hiding this comment.
I've made a similar proposal in #1249, but we ended up not moving forward with it.
| @Priority(Priorities.LIBRARY + 200) | ||
| public class ProfileConfigSourceInterceptor implements ConfigSourceInterceptor { | ||
| private static final long serialVersionUID = -6305289277993917313L; | ||
|
|
||
| private static final Converter<ArrayList<String>> PROFILES_CONVERTER = newCollectionConverter( |
| return hashCode; | ||
| } | ||
|
|
||
| private int buildHashCode() { |
| @@ -28,7 +28,7 @@ public ConfigValue getValue(final ConfigSourceInterceptorContext context, final | |||
|
|
|||
| @Override | |||
| public Iterator<String> iterateNames(final ConfigSourceInterceptorContext context) { | |||
| if (SecretKeys.isLocked()) { | |||
| if (!secrets.isEmpty() && SecretKeys.isLocked()) { | |||
| @@ -1142,6 +1078,14 @@ static <T> Converter<T> getConverter(Class<? extends T> clazz) { | |||
| return new HyphenateEnumConverter(clazz); | |||
| } | |||
|
|
|||
| // some shortcuts for common used classes | |||
| if ("java.io.File".equals(clazz.getName())) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@radcortez I pushed several suggestions here. Some are easy wins that we could apply without too much discussion, some are maybe more controversial.
I would very much like to discuss Provide some shortcuts for simple config properties as this commit clearly removes some work (and I checked the generated bytecode and it looks like it's actually less work) but it seems to make things a bit slower and I wasn't able to pinpoint what was going on.
Interested in your feedback :).