Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to use Optional on payloads #2229

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Make it possible to use Optional on payloads #2229

merged 1 commit into from
Nov 22, 2024

Conversation

velo
Copy link
Contributor

@velo velo commented Nov 21, 2024

This PRs supplements #1731

Make it possible to have Optional Strings too

t1
t1 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@t1 t1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The tests could also test more complex scenarios, e.g. something like Optional<List<Optional<String>>>; but I guess it's good enough.

jmartisk
jmartisk approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@jmartisk jmartisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmartisk jmartisk merged commit a274111 into smallrye:main Nov 22, 2024
5 checks passed
@velo velo deleted the optional_strings branch November 22, 2024 11:55
@velo
Copy link
Contributor Author

velo commented Nov 25, 2024

Thanks a lot.

Any idea when next release will come out?

@jmartisk
Copy link
Member

AFAIK we can't release right now because @radcortez is migrating to a new release process - is that right?
Hopefully we will be able to get SmallRye GraphQL 2.12 out for Quarkus 3.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartisk jmartisk jmartisk approved these changes

@t1 t1 t1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@velo @jmartisk @t1