Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registration authority support #62

Merged
merged 17 commits into from
Jul 22, 2021
Merged

Add registration authority support #62

merged 17 commits into from
Jul 22, 2021
+174 −6

Conversation

estenrye
Copy link
Contributor

@estenrye estenrye commented Jul 20, 2021 •
edited
Loading

This PR adds the following capabilities

  • All public certificates are now optionally injectable
  • Secrets are now optionally injectable
  • CA and Provisioner passwords are now optionally injectable
  • Adds ability to inject a Certificate Issuer password
  • Adds ability to configure and inject both JWK and X5C Registration Authority Credentials
  • Enables deployment as a Deployment object.
  • Adds documentation for adding helm repo

Addresses the following issues:
#1
#52
#61

estenrye added 12 commits July 19, 2021 16:40
@estenrye
Update documentation to incluce helm repo add.
beee137 
Addresses #1
@estenrye
Adds ability to optionally inject ssh and x509 data.
24d42aa 
Adds the `enabled` flag to these secrets sections to allow
the user to optionally disable injection of these certs and keys.

Addresses smallstep#52
@estenrye
rework documentation wording
168db57 
smallstep#56
@estenrye
Add ability to inject required information for RA
81e0ca0 
Adds the capability to inject JWK and X5C provisioner keys
for configuring a Smallstep Registration Authority.

Addresses smallstep#61
@estenrye
fix syntax error in condition
ca6cbaa
@estenrye
fix reference error in condition
64d3faa
@estenrye
RA is running
0b0c7d1
@estenrye
enable Deployments
3ca0fd7
@estenrye
Add example values.yml
17d8850
@estenrye
Merge branch 'master' of github.com:estenrye/smallstep-helm-charts in…
dac5dd7 
…to add-registration-authority-support
@estenrye
remove db section
84f9540
@estenrye
bump version
fdeb486
@maraino maraino self-requested a review July 20, 2021 17:02
@maraino maraino added the needs triage Waiting for discussion / prioritization by team label Jul 20, 2021
maraino
maraino requested changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @estenrye, this is great; I've added some feedback regarding the issuer key. In most cases, you don't need to configure it, so it should be optional.

@maraino maraino self-requested a review July 22, 2021 18:03
@maraino maraino removed the needs triage Waiting for discussion / prioritization by team label Jul 22, 2021
maraino
maraino approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @estenrye

@maraino maraino merged commit 2cb1211 into smallstep:master Jul 22, 2021
@ddesai2-sc ddesai2-sc mentioned this pull request Feb 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@estenrye @maraino