Apply suggestions from shellcheck

Signed-off-by: Stefan Marr <[email protected]>

benchmarks/Crystal/build.sh

@@ -1,13 +1,13 @@
 #!/bin/bash
 set -e # make script fail on first error
-SCRIPT_PATH=$(dirname $0)
-source $SCRIPT_PATH/../script.inc
+SCRIPT_PATH="$(dirname "$0")"
+source "$SCRIPT_PATH/../script.inc"
 
 if [[ "$1" = "style" ]]
 then
     exit 0
 fi
 
 INFO Build Crystal Benchmarks
-pushd $SCRIPT_PATH
+pushd "$SCRIPT_PATH"
 crystal build --release --no-debug harness.cr

benchmarks/Java/build.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 set -e # make script fail on first error
-SCRIPT_PATH=$(dirname $0)
-source $SCRIPT_PATH/../script.inc
-pushd $SCRIPT_PATH
+SCRIPT_PATH="$(dirname "$0")"
+source "$SCRIPT_PATH/../script.inc"
+pushd "$SCRIPT_PATH"
 
 if [[ "$1" = "style" ]]
 then

benchmarks/JavaScript/build.sh

@@ -1,13 +1,13 @@
 #!/bin/bash
 set -e # make script fail on first error
-SCRIPT_PATH=$(dirname $0)
-source $SCRIPT_PATH/../script.inc
+SCRIPT_PATH="$(dirname "$0")"
+source "$SCRIPT_PATH/../script.inc"
 
 INFO Build Node.js Benchmarks
 if [[ "$1" = "style" ]]
 then
   INFO Check style of JavaScript benchmarks
-  pushd $SCRIPT_PATH
+  pushd "$SCRIPT_PATH"
   npx eslint .
 else
   exit 0

benchmarks/Lua/build.sh

@@ -1,13 +1,13 @@
 #!/bin/bash
 set -e # make script fail on first error
-SCRIPT_PATH=$(dirname $0)
+SCRIPT_PATH="$(dirname "$0")"
 source $SCRIPT_PATH/../script.inc
 
 if [[ "$1" = "style" ]]
 then
   INFO Check style of Lua benchmarks
-  pushd $SCRIPT_PATH
-  luacheck *.lua
+  pushd "$SCRIPT_PATH"
+  luacheck ./*.lua
 else
   exit 0
 fi

benchmarks/Python/build.sh

@@ -1,16 +1,16 @@
 #!/bin/bash
 set -e # make script fail on first error
-SCRIPT_PATH=$(dirname $0)
-source $SCRIPT_PATH/../script.inc
+SCRIPT_PATH="$(dirname "$0")"
+source "$SCRIPT_PATH/../script.inc"
 
 if [[ "$1" = "style" ]]
 then
   INFO Check style of Python benchmarks
-  pushd $SCRIPT_PATH
+  pushd "$SCRIPT_PATH"
   if [[ "$2" != "skip-black-for-python" ]]; then
     python -m black --check --diff .
   fi
-  python -m pylint *.py som
+  python -m pylint ./*.py som
 else
   exit 0
 fi

benchmarks/Ruby/build.sh

@@ -1,12 +1,12 @@
 #!/bin/bash
 set -e # make script fail on first error
-SCRIPT_PATH=$(dirname $0)
-source $SCRIPT_PATH/../script.inc
+SCRIPT_PATH="$(dirname "$0")"
+source "$SCRIPT_PATH/../script.inc"
 
 if [[ "$1" = "style" ]]
 then
   INFO Check style of Ruby benchmarks
-  pushd $SCRIPT_PATH
+  pushd "$SCRIPT_PATH"
   rubocop
 else
   exit 0

benchmarks/SOM/build.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 set -e # make script fail on first error
-SCRIPT_PATH=$(dirname $0)
-source $SCRIPT_PATH/../script.inc
+SCRIPT_PATH="$(dirname "$0")"
+source "$SCRIPT_PATH/../script.inc"
 
 if [[ "$1" = "style" ]]
 then

benchmarks/SOMns/build.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 set -e # make script fail on first error
-SCRIPT_PATH=$(dirname $0)
-source $SCRIPT_PATH/../script.inc
+SCRIPT_PATH="$(dirname "$0")"
+source "$SCRIPT_PATH/../script.inc"
 
 if [[ "$1" = "style" ]]
 then

benchmarks/Smalltalk/build.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 set -e # make script fail on first error
-SCRIPT_PATH="$(dirname $0)"
+SCRIPT_PATH="$(dirname "$0")"
 source "$SCRIPT_PATH/../script.inc"
 
 if [[ "$1" = "style" ]]

benchmarks/script.inc

@@ -1,13 +1,13 @@
 #!/bin/bash
 
 # make SCRIPT_PATH absolute
-pushd $(dirname $0) > /dev/null
-SCRIPT_PATH=`pwd`
-popd > /dev/null
+pushd "$(dirname "$0")" > /dev/null || exit 1
+export SCRIPT_PATH="$(pwd)"
+popd > /dev/null || exit 1
 
 # set up color commands
-if [ -t 1 -a -t 2 -a \( `type -t tput` = "file" \) ]; then
-  _colors=`tput colors`
+if [ -t 1 ] && [ -t 2 ] && [ \( "$(type -t tput)" = "file" \) ]; then
+  _colors=$(tput colors)
   if [ "$_colors" -ge 256 ]; then
     INFO () { tput setaf 33;  /bin/echo "$@"; tput sgr0; }
     OK   () { tput setaf 28;  /bin/echo "$@"; tput sgr0; }
@@ -26,64 +26,6 @@ else
   ERR  () { /bin/echo "$@"; }
 fi
 
-
-function get_web_getter() {
-  # get a getter
-  if [ \! -z `type -t curl` ]; then
-    GET="curl --silent --location --compressed -O"
-  elif [ \! -z `type -t wget` ]; then
-    GET="wget --quiet"
-  else
-    ERR "No getter (curl/wget)"
-    exit 1
-  fi
-  OK Getter is \"$GET\"
-}
-
-function check_for_tools() {
-  INFO -n 'Tools: '
-  for tool in $@; do
-    if [ -x `type -t $tool` ]; then
-      WARN -n No $tool
-    else
-      INFO -n "$tool "
-    fi
-  done
-  OK ok.
-}
-
-function get_pypy() {
-  if [ \! -d pypy ]; then
-    get_web_getter
-
-    INFO Get PyPy Source
-    PYPY_VERSION="5.8.0"
-    PYPY_DIR="pypy2-v${PYPY_VERSION}-src"
-    PYPY_TAR="${PYPY_DIR}.tar.bz2"
-    DOWNLOAD_URL="https://bitbucket.org/pypy/pypy/downloads/${PYPY_TAR}"
-    $GET $DOWNLOAD_URL || $GET $DOWNLOAD_URL
-    tar -xjf $PYPY_TAR
-    mv $PYPY_DIR pypy
-  else
-    OK Got PyPy Source
-  fi
-}
-
-function get_jdk9ea() {
-  JDK_ARCHIVE=jdk-9-ea+96_linux-x64_bin.tar.gz
-  JDK_URL=http://www.java.net/download/jdk9/archive/96/binaries/$JDK_ARCHIVE
-  JDK_DIR=jdk-9
-
-  INFO Get JDK9 Early Access from $JDK_URL
-  if [ \! -d "$JDK_DIR" ]; then
-    $GET $JDK_URL || $GET $JDK_URL
-    tar -xzf $JDK_ARCHIVE
-    OK Got JDK Early Access
-  else
-    OK Have JDK Early Access
-  fi
-}
-
 function load_git_repo() {
   INFO Cloning "$1" into "$2"
   if [[ -z "$3" ]]
@@ -100,10 +42,10 @@ function load_submodule() {
 }
 
 function check_for() {
-  if [ ! -x `which $1` ]
+  if [ ! -x "$(which "$1")" ]
   then
     ERR "$1 binary not found. $2"
-    if [ "non-fatal" -ne "$3" ]
+    if [ "non-fatal" != "$3" ]
     then
       exit 1
     fi