Lazily initialize backing store of Vector #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This way, we test it in CI to a degree. Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
smarr
force-pushed
the
empty-initial-vector
branch
from
eb41111 to
78f407d
Compare
Signed-off-by: Stefan Marr <[email protected]>
Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the discussion of #84 the initialization strategy of Vector was discussed.
Before this PR, it would create an array of 50 elements in the default case.
This PR changes Vector to not create an array at the beginning, and instead initialize the
storagewithnull. The access operations are adapted to check fornullwhere needed and initialize thestoragearray on demand.The size of the initial array is also decreased to 10. This choice is made mostly based on results from large program corpuses where people found that arrays tent to be small, usually have few elements. Though, I didn't investigate what the size distribution for our benchmarks here is.
The PR also has a few other minor cleanups.