Add Bitlayer OCR configs to CCIP #1543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simsonraj
reviewed
Nov 19, 2024
| FinalityTagEnabled = false | ||
| FinalityDepth = 21 # confirmed with Bitlayer team and reccomended by docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutFinality/#about-finality-at-stage-bitlayer-pos-bitlayer-mainnet-v1 | ||
|
|
||
| [EVM.GasEstimator] |
There was a problem hiding this comment.
Do we want to try the Fee History estimator? if its easier to run another quick tests with FHE?
That would avoid the need to set all these Price values in the config
There was a problem hiding this comment.
I had considered the Fee History estimator, but eth_FeeHistory is not supported by Bitlayer. They support a similar RPC method (eth_FeeHistory2), but this would require core code modification to support. (docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/Json-RPC/)
There was a problem hiding this comment.
We can still use the FHE & disable the EIP1559?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why