Add 1.5.1 pools #1551
Merged
Add 1.5.1 pools #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
RensR
force-pushed
the
import-1.5.1-pools
branch
from
e4a660f
to
8a24514
Compare
|
RensR
force-pushed
the
import-1.5.1-pools
branch
from
85696e5
to
31097f0
Compare
RensR
requested review from
winder,
rstout,
asoliman92,
dimkouv,
mateusz-sekara and
0xnogo
RensR
force-pushed
the
import-1.5.1-pools
branch
from
31097f0
to
9214ff3
Compare
matYang
approved these changes
Nov 28, 2024
0xsuryansh
approved these changes
Nov 29, 2024
RayXpub
reviewed
Nov 29, 2024
| /// Example: | ||
| /// Assume there is a token with 6 decimals on chain A and 3 decimals on chain B. | ||
| /// - 1.123456 tokens are burned on chain A. | ||
| /// - 1.234 tokens are minted on chain B. |
There was a problem hiding this comment.
q: shouldn't it be 1.123?
RayXpub
reviewed
Nov 29, 2024
| @@ -78,7 +78,7 @@ contract USDCTokenPool is TokenPool, ITypeAndVersion { | |||
| address[] memory allowlist, | |||
| address rmnProxy, | |||
| address router | |||
| ) TokenPool(token, allowlist, rmnProxy, router) { | |||
| ) TokenPool(token, 6, allowlist, rmnProxy, router) { | |||
There was a problem hiding this comment.
nit: use constant instead of magic number
RayXpub
reviewed
Nov 29, 2024
| import {HybridLockReleaseUSDCTokenPool} from "../../../../pools/USDC/HybridLockReleaseUSDCTokenPool.sol"; | ||
| import {HybridLockReleaseUSDCTokenPoolSetup} from "./HybridLockReleaseUSDCTokenPoolSetup.t.sol"; | ||
|
|
||
| contract HybridLockReleaseUSDCTokenPool_TransferLiquidity is HybridLockReleaseUSDCTokenPoolSetup { |
There was a problem hiding this comment.
Suggested change
| contract HybridLockReleaseUSDCTokenPool_TransferLiquidity is HybridLockReleaseUSDCTokenPoolSetup { | |
| contract HybridLockReleaseUSDCTokenPool_transferLiquidity is HybridLockReleaseUSDCTokenPoolSetup { |
RayXpub
approved these changes
Nov 29, 2024
mateusz-sekara
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.