Feature/27989 Ledger tx signature #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodrigoAD
reviewed
Feb 7, 2022
RodrigoAD
reviewed
Feb 8, 2022
RodrigoAD
reviewed
Feb 9, 2022
RodrigoAD
reviewed
Feb 9, 2022
RodrigoAD
reviewed
Feb 9, 2022
RodrigoAD
force-pushed
the
feature/27989-ledger-support
branch
from
da06037 to
a5ce10b
Compare
krebernisak
requested changes
Feb 9, 2022
krebernisak
reviewed
Feb 9, 2022
krebernisak
reviewed
Feb 9, 2022
krebernisak
reviewed
Feb 9, 2022
krebernisak
approved these changes
Feb 10, 2022
RodrigoAD
added a commit
that referenced
this pull request
Feb 11, 2022
* 27989: LedgerKey class extending base Key * 27989: adjusting withWallet middleware to sign tx with ledger if requested * 27989: Adding await to invokeMiddlewares * 27989: Making LedgerKey constructor private * 27989: prevent LedgerKey from keeping connection to the ledger open * 27989: adding secp256k1 to parse the signature * 27989: redefining createSignature in LedgerKey to comply with amino encoding * 27979: LedgerKey centralised error handling * 27989: LedgerKey signing in legacy amino signing mode * 27989: signatureImport input data changed straight to buffer * 27989: Passing signMode straight into createAndSignTx * 27989: formatting * regenerate yarn lock * fix integer validation on set billing * updated deps * 27989: BIP44 compliant path parsing * 27989: checkForErrors -> assertNoErrors * add libusb1 to nix to solve the libudev issue * 27989: Formatting * Fix upload test to use yarn instead of executable Co-authored-by: RodrigoAD <[email protected]> Co-authored-by: Tate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.