update linter rules and fix issues #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If there's nothing transmitted yet, an implementation will not have emitted an event, | ||
| // or may not find details of a latest transmission on-chain if it's a function call. | ||
| // A zeroed out latestTransmissionDetailsResponse tells later parts of the system that there's no data yet. | ||
| c.lggr.Warn("LatestTransmissionDetails not found", "err", err) | ||
| } | ||
|
|
||
| // Depending on if there is a LatestAnswer or not, and the implementation of the ChainReader, |
patrickhuie19
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was started in pursuit of https://smartcontract-it.atlassian.net/browse/BCF-3203 but there were no instances of
containedctxviolations. The ruleset was out of date besides, and updating everything only flagged two issues, which are fixed.