Add NewHeadsPollInterval #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanTinianov
changed the title
dhaidashenko
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Changing the metric's name is a breaking change. They might be used by NOPs and other teams for alerts or in dashboards. We can't do that without decent argumentation and a long deprecation/migration process.
Let's talk to James; maybe it's possible to prioritize the update of chainlink/v2 in the integration tests.
If not we can make 2.14 to use metrics defined in the framework repo.
DylanTinianov
changed the title
dhaidashenko
approved these changes
Jan 15, 2025
Farber98
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NewHeadsPollIntervalto multinode configResolves Dependencies
Required for extracting Solana MultiNode to chainlink-framework: smartcontractkit/chainlink-solana#1004