-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1725] doc generating pipeline #1447
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tofel
force-pushed
the
tt-1725-doc-generating-pipeline
branch
from
December 6, 2024 11:27
b8b9937
to
17d91a0
Compare
skudasov
approved these changes
Dec 6, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new workflow that generates go doc for public functions modified in the PR, if they do not have any function docs.
It is triggered only when label
generate_go_docs
is present.You can see it in action here, where it added comment for functions from this PR.
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes enhance the GitHub Actions workflow for automatically generating Go documentation upon pull request updates. They streamline the process by adjusting the trigger to react to pull request label changes, improving security through the use of GitHub tokens, and refining the documentation generation process to only include changed modules. This ensures that documentation is efficiently updated in a secure manner, focusing only on the parts of the codebase that have been modified.
What
id-token: write
for enhanced security and adjustedcontents: read
permission.dorny/paths-filter
action. This optimizes the workflow by focusing on the parts of the codebase that have been modified.peter-evans/create-pull-request
action and to dynamically set the branch, base, title, and body according to the current PR context. This ensures the documentation PR is accurately targeted and described.