Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logs from flakeguard all test results #1453

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

lukaszcl
Copy link
Contributor

@lukaszcl lukaszcl commented Dec 9, 2024


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes optimize the process of saving JSON reports by removing logs from test results in the aggregated report before saving, thus streamlining the data presented for easier analysis. Also, the introduction of buffered writing improves performance and efficiency when saving these reports to disk.

What

  • tools/flakeguard/cmd/aggregate_results.go:
    • Removed saving the aggregated report and filtering failed tests until after logs are removed from the aggregated report's test results.
    • Added removal of logs from test results in the aggregated report before saving, improving clarity and size of the saved report.
    • Reordered operations to save the aggregated report without logs after the logs have been removed, ensuring a more concise and relevant report.
  • tools/flakeguard/reports/io.go:
    • Added bufio package to use buffered writing, enhancing file writing performance.
    • Modified SaveReport function to use os.OpenFile with truncation mode and a buffered writer, improving efficiency and handling of file saving operations.

@lukaszcl lukaszcl requested review from sebawo and a team as code owners December 9, 2024 15:16
@app-token-issuer-test-toolings

Go doc generation

Hey @lukaszcl, you can check generated Go function documentation here. Please review them and merge to this PR once you're satisfied with them.

@cl-sonarqube-production
Copy link

@lukaszcl lukaszcl merged commit 404e04e into main Dec 9, 2024
44 of 45 checks passed
@lukaszcl lukaszcl deleted the flakeguard-no-outputs-in-all-results branch December 9, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants