Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCI-2564] - TXM feature to drop stale unstarted transactions #13874

Closed
wants to merge 12 commits into from

Conversation

Farber98
Copy link
Contributor

@Farber98 Farber98 commented Jul 17, 2024

Description

Through this PR we are adding a new flow within /v2/keys/evm/chain WEB API endpoint to be able to drop 'unstarted' txes that are considered stale. New functionality will be exposed in the node operator UI (see UI changes).

How it works

When we mark abandonUnstarted = true, we can optionally pass a subject

  • If no subject is provided, ALL 'unstarted' txes will be DELETED.
  • If a subject is provided, we only delete THOSE SUBJECT 'unstarted' txes.

Acceptance Criteria

  • Be able to delete 'unstarted' stale txes from a button within Node Operator UI.

Tickets:

Unblocks:

Mitigates:

@Farber98 Farber98 self-assigned this Jul 17, 2024
@Farber98 Farber98 requested review from a team as code owners July 17, 2024 15:49
@Farber98
Copy link
Contributor Author

Farber98 commented Jul 17, 2024

subject should be optional or mandatory?

Note: I'm assuming subject is a way to classify certain operations, but not sure what exactly we are classifying. Same product txes? Same NOP process txes?

@Farber98
Copy link
Contributor Author

Farber98 commented Jul 17, 2024

If subject is optional and defaults to empty, is desired to delete all 'unstarted' txes when this occurs?

@Farber98
Copy link
Contributor Author

Farber98 commented Jul 17, 2024

Do we want to be able to abandon and abandonUnstarted on the same query? Are there any risk of some collision doing this? Should we limit that only one can occur in the same query?

@Farber98 Farber98 marked this pull request as draft July 17, 2024 15:50
@Farber98 Farber98 marked this pull request as ready for review July 18, 2024 17:33
@Farber98 Farber98 closed this Aug 2, 2024
@Farber98
Copy link
Contributor Author

Farber98 commented Aug 2, 2024

Dropped in favour of https://smartcontract-it.atlassian.net/browse/BCI-3901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant