Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Read Error Format #15223

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Correct Read Error Format #15223

merged 4 commits into from
Nov 19, 2024

Conversation

EasterTheBunny
Copy link
Contributor

Changed error text to be read error instead of rpc error to limit confusion. Batch flag to string corrected to show true|false instead of bool type.

@EasterTheBunny EasterTheBunny requested review from a team as code owners November 13, 2024 15:23
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@EasterTheBunny
Correct Read Error Format
9b786b7 
Changed error text to be `read error` instead of `rpc error` to limit confusion.
Batch flag to string corrected to show `true|false` instead of bool type.
@EasterTheBunny
only write batch for batch calls
bab14d5
@EasterTheBunny
convert batch boolean to enum
632723e
@EasterTheBunny
fixed linting by changing to
f3e152f
@EasterTheBunny EasterTheBunny added this pull request to the merge queue Nov 19, 2024
Merged via the queue into develop with commit 7a5d460 Nov 19, 2024
139 of 141 checks passed
@EasterTheBunny EasterTheBunny deleted the ah/read-error-update branch November 19, 2024 16:07
cedric-cordenier pushed a commit that referenced this pull request Nov 20, 2024
@EasterTheBunny @cedric-cordenier
Correct Read Error Format (#15223)
0487a8f 
* Correct Read Error Format

Changed error text to be `read error` instead of `rpc error` to limit confusion.
Batch flag to string corrected to show `true|false` instead of bool type.

* only write batch for batch calls

* convert batch boolean to enum

* fixed linting by changing to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija42 ilija42 ilija42 approved these changes

@Farber98 Farber98 Farber98 approved these changes

@jmank88 jmank88 jmank88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EasterTheBunny @jmank88 @Farber98 @ilija42