-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-4165 additional e2e integration tests #15245
base: develop
Are you sure you want to change the base?
CCIP-4165 additional e2e integration tests #15245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Are there any commonalities from each test case that can be pulled out into funcs? See e.g messagingTestCase
in ccip_messaging_test.go
integration-tests/smoke/ccip_test.go
Outdated
require.NoError(t, err) | ||
|
||
_, err = e.Chains[tenv.HomeChainSel].Confirm(tx) | ||
require.NoError(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To aid in readability, can we have all of this setup in a separate function, with a docstring describing what is being done? e.g
// setupPricingTest deploys transferable tokens on the source and dest,
// mints tokens on both, ....
func setupPricingTest(...) {
// the above code, from lines 352 to 399
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I'll see what I can do.
integration-tests/smoke/ccip_test.go
Outdated
_, err = e.Chains[tenv.HomeChainSel].Confirm(tx) | ||
require.NoError(t, err) | ||
|
||
t.Run("Send Token Pay with Link token home chain -> remote", func(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: are these test cases runnable separately or do they depend on each other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can be run independently, the ticket request asked that they be put in this way and run sequentially under the umbrella of a single test.
…or-tokens-transfers-tests
…or-tokens-transfers-tests
…or-tokens-transfers-tests
…or-tokens-transfers-tests
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , Core Tests (go_core_tests) , lint , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Deployment Project , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan 1. Invalid version: unknown revision[A 1 <= 10 words sentence that describes the error]:[Install flakeguard] Source of Error:
Why: The error occurred because the specified revision Suggested fix: Verify the correct revision hash for AER Report: Operator UI CI ran successfully ✅ |
…or-tokens-transfers-tests
…or-tokens-transfers-tests
Additional End-to-End integration tests for CCIP involving token transfers paying in different feeTokens