Fix ABI compatibility issues

[Oozyx]

After going through the deployment steps, we've discovered some inconsistencies with the ABI compared to AccessControlledOCR2Aggregator contract.

These changes will make the DualAggregator compatible with existing gauntlet tooling:

• minAnswer() / maxAnswer(). Simply making the immutable state variables public was an implementation error. Getters should not be i_minAnswer() / i_maxAnswer()

• VERSION constant should be internal. We already have a public getter: version()

• DualAggregator now inherits from SimpleReadAccessController. This is the same as the original aggregator contract. SimpleReadAccessController inherits from Ownable therefore no functionality is lost.

[github-actions]

I see you updated files related to contracts. Please run pnpm changeset in the contracts directory to add a changeset.

[github-actions]

AER Report: Operator UI CI

aer_workflow , commit , Breaking Changes GQL Check

1. Workflow failed to complete successfully:[Breaking Changes GQL Check]

Source of Error:

2024-11-22T19:34:22.4162515Z Checking conclusion [failure]
2024-11-22T19:34:22.4163232Z Checking status [completed]
2024-11-22T19:34:22.4165482Z Conclusion is not success, it's [failure].
2024-11-22T19:34:22.4166705Z Propagating failure to upstream job

Why: The workflow run triggered by the convictional/trigger-workflow-and-wait action did not complete successfully. The status checked was completed, but the conclusion was failure.

Suggested fix: Investigate the logs of the triggered workflow (ID: 11978951461) to identify the specific reason for the failure and address the underlying issue.

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Find New Flaky Tests / Find Tests To Run , Core Tests (go_core_tests) , Core Tests (go_core_ccip_deployment_tests) , lint , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests / Run Tests , Find New Flaky Tests / Report , SonarQube Scan , Flakey Test Detection

1. Error while fetching channel definitions: oracle_streams_0

Source of Error:

2024-11-21T19:32:23.302Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 20}

2024-11-21T19:32:38.303Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 21}

2024-11-21T19:32:53.303Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 22}

2024-11-21T19:33:08.304Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 23}

2024-11-21T19:33:23.305Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 24}

2024-11-21T19:33:38.305Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 25}

2024-11-21T19:33:53.305Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 26}

2024-11-21T19:34:08.306Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 27}

2024-11-21T19:34:23.307Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 28}

2024-11-21T19:34:38.308Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 29}

2024-11-21T19:34:53.308Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 30}

2024-11-21T19:35:08.309Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 31}

2024-11-21T19:35:23.309Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 32}

2024-11-21T19:35:38.310Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 33}

2024-11-21T19:35:53.311Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 34}

2024-11-21T19:36:08.311Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 35}

2024-11-21T19:36:23.312Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 36}

2024-11-21T19:36:38.313Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 37}

2024-11-21T19:36:53.314Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "7a605c36fd4a7c0ed969c1262d3b2ff683a4c562e7f82aa57fc8eceb50bf308c", "err": "error making http request: Get \"http://127.0.0.1:38327\": context canceled", "attempt": 38}

2024-11-21T19:37:08.315Z	WARN	oracle_streams_0.EVM.1337.Relayer.ChannelDefinitionCache	llo/onchain_channel_definition_cache.go:327	Error while fetching channel definitions	{"version": "2.18.0@00a0b7d", "addr": "0x011221D7100da94ecD6949851966Be8ed050f2D3", "fromBlock": 1, "version": 2, "url": "http://127.0.0.1:38327", "sha": "
</cicore>

[github-actions]

Static analysis results are available

Hey @Oozyx, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube