Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump geth to v1.14.13 #15375

Closed
wants to merge 2 commits into from
Closed

bump geth to v1.14.13 #15375

wants to merge 2 commits into from

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Nov 21, 2024

It looks like params.Version was removed, so we will have to find a work around.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , GolangCI Lint (core/scripts) , GolangCI Lint (.) , test-scripts , GolangCI Lint (integration-tests) , Core Tests (go_core_tests) , GolangCI Lint (deployment) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Uncommitted changes detected after generate: [Ensure clean after generate]

Source of Error:
Ensure clean after generate	2025-02-13T00:25:08.7816352Z ##[error]Process completed with exit code 1.

Why: The git diff --stat --cached --exit-code command detected changes in the repository after the generate step, indicating that the repository is not clean.

Suggested fix: Ensure that all generated files are committed or that the generate step does not produce any uncommitted changes.

2. TestLogPoller_PollAndSaveLogs failed: [Run tests]

Source of Error:
Run tests	2025-02-13T00:23:49.9010919Z --- FAIL: TestLogPoller_PollAndSaveLogs (4.11s)
Run tests	2025-02-13T00:23:49.9012052Z --- FAIL: TestLogPoller_PollAndSaveLogs/fixed_finality_depth_without_finality_tag (2.07s)
Run tests	2025-02-13T00:23:49.9056014Z logger.go:146: 00:21:48.270805911	DEBUG	LogPoller	Unfinalized log query	{"version": "unset@unset", "logs": 0, "currentBlockNumber": 3, "blockHash": "0xa66d13fb7d2e1878f8156b7239d57171c46ee52257f3b0e41632d6456cb62f5d", "timestamp": "00:21:49.000000000"}
Run tests	2025-02-13T00:23:49.9057805Z log_poller_test.go:900: 
Run tests	2025-02-13T00:23:49.9059456Z 	Error Trace:	/home/runner/work/chainlink/chainlink/core/chains/evm/logpoller/log_poller_test.go:900
Run tests	2025-02-13T00:23:49.9060916Z 	Error: 	Not equal: 
Run tests	2025-02-13T00:23:49.9061668Z 	 	expected: 1
Run tests	2025-02-13T00:23:49.9062389Z 	 	actual : 0
Run tests	2025-02-13T00:23:49.9063376Z 	Test: 	TestLogPoller_PollAndSaveLogs/fixed_finality_depth_without_finality_tag

Why: The test TestLogPoller_PollAndSaveLogs failed because the expected number of logs (1) did not match the actual number of logs (0).

Suggested fix: Investigate why the log poller is not retrieving the expected logs. Ensure that the log poller is correctly configured and that the test environment is set up to produce the expected logs.

3. TestLogPoller_PollAndSaveLogsDeepReorg failed: [Run tests]

Source of Error:
Run tests	2025-02-13T00:23:49.9102332Z --- FAIL: TestLogPoller_PollAndSaveLogsDeepReorg (4.39s)
Run tests	2025-02-13T00:23:49.9104514Z logger.go:146: 00:21:46.220653131	DEBUG	LogPoller	New logger: LogPoller	{"version": "unset@unset"}
Run tests	2025-02-13T00:23:49.9105766Z logger.go:146: 00:21:46.252757828	DEBUG	LogPoller	Polling for logs	{"version": "unset@unset", "currentBlockNumber": 1}
Run tests	2025-02-13T00:23:49.9106880Z logger.go:146: 00:21:46.253326723	DEBUG	LogPoller	Latest blocks read from chain	{"version": "unset@unset", "latest": 2, "finalized": 1}
Run tests	2025-02-13T00:23:49.9112130Z logger.go:146: 00:21:46.257327267	DEBUG	LogPoller	Unfinalized log query	{"version": "unset@unset", "logs": 1, "currentBlockNumber": 2, "blockHash": "0xebceea869f38bc36c1426f4f684a6981589d68e970ca4b5c2ecca0515137ac12", "timestamp": "00:21:47.000000000"}
Run tests	2025-02-13T00:23:49.9113331Z helper_test.go:72: waiting for forked txes to be pending, have 0, want true
Run tests	2025-02-13T00:23:49.9114004Z helper_test.go:72: waiting for forked txes to be pending, have 0, want true
Run tests	2025-02-13T00:23:49.9114666Z helper_test.go:72: waiting for forked txes to be pending, have 0, want true
Run tests	2025-02-13T00:23:49.9115326Z helper_test.go:72: waiting for forked txes to be pending, have 1, want true
Run tests	2025-02-13T00:23:49.9116223Z logger.go:146: 00:21:48.362535428	DEBUG	LogPoller	Polling for logs	{"version": "unset@unset", "currentBlockNumber": 3}
Run tests	2025-02-13T00:23:49.9117338Z logger.go:146: 00:21:48.363137979	DEBUG	LogPoller	Latest blocks read from chain	{"version": "unset@unset", "latest": 35, "finalized": 32}
Run tests	2025-02-13T00:23:49.9118475Z logger.go:146: 00:21:48.365689587	INFO	LogPoller	Reorg detected	{"version": "unset@unset", "blockAfterLCA": 2, "currentBlockNumber": 3}
Run tests	2025-02-13T00:23:49.9120812Z logger.go:146: 00:21:48.370590666	DEBUG	LogPoller	Got blocks from log poller	{"version": "unset@unset", "blockNumbers": []}
Run tests	2025-02-13T00:23:49.9122506Z logger.go:146: 00:21:48.370640559	DEBUG	LogPoller	Falling back to RPC for blocks not found in log poller blocks table	{"version": "unset@unset", "remainingBlocks": [23, 24, 4, 16, 17, 20, 22, 26, 29, 10, 13, 9, 11, 14, 15, 21, 30, 31, 3, 6, 8, 25, 5, 18, 19, 27, 7, 12, 28]}
Run tests	2025-02-13T00:23:49.9186589Z logger.go:146: 00:21:48.384472031	DEBUG	LogPoller	Backfill found logs	{"version": "unset@unset", "from": 2, "to": 31, "logs": 30, "blocks": [{"EvmChainId":null,"BlockHash":"0x70ebd28ee7b5b156e6b9fe50186d585d0cd117f0d461a964b18c6f5e3d78c9d5","BlockNumber":3,"BlockTimestamp":"2025-02-13T00:21:49Z","FinalizedBlockNumber":3,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x70ebd28ee7b5b156e6b9fe50186d585d0cd117f0d461a964b18c6f5e3d78c9d5","BlockNumber":3,"BlockTimestamp":"2025-02-13T00:21:49Z","FinalizedBlockNumber":3,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x075877a152221e048ee67a975de287e2e7fe9c6a83ed3b3d3e0c1fade33302f3","BlockNumber":4,"BlockTimestamp":"2025-02-13T00:21:50Z","FinalizedBlockNumber":4,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xb3764b3c0d6d55f87b76096ce8403f3eee83af3c74e2a53d8105685236efeb49","BlockNumber":5,"BlockTimestamp":"2025-02-13T00:21:51Z","FinalizedBlockNumber":5,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xd28bbb61a36fed8d49d6e99d917a1c75eee526ce8fce9ed329a148b8da2cba69","BlockNumber":6,"BlockTimestamp":"2025-02-13T00:21:52Z","FinalizedBlockNumber":6,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x3e03197d470ebd5baeb838c143ffee7ac8a982fd4dc133ea9fce7d42bc273ff0","BlockNumber":7,"BlockTimestamp":"2025-02-13T00:21:53Z","FinalizedBlockNumber":7,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x3d86ceb21e13d6b6808ad5e77ceb5a06094a74c9f53927634c0f818894342fc8","BlockNumber":8,"BlockTimestamp":"2025-02-13T00:21:54Z","FinalizedBlockNumber":8,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x9de581c68cf51e0efddbe1c85dd425c7efeeaa487eb72a370aee778fb0a1dd1d","BlockNumber":9,"BlockTimestamp":"2025-02-13T00:21:55Z","FinalizedBlockNumber":9,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x414eadfc791e5394947079c3690809677e3ed03c81d797c06fcc3b0799f61c48","BlockNumber":10,"BlockTimestamp":"2025-02-13T00:21:56Z","FinalizedBlockNumber":10,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xd23ada6d2c97d3272c7c83d2494fd8b65038c8dc7f8a8dca41deaa210293c957","BlockNumber":11,"BlockTimestamp":"2025-02-13T00:21:57Z","FinalizedBlockNumber":11,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xebac2920f34250697b5937cf4d19d1a947ae4b61e9250ca2a79f3f3207b08cca","BlockNumber":12,"BlockTimestamp":"2025-02-13T00:21:58Z","FinalizedBlockNumber":12,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x791f2b2585c1c5c7de83a3612f9c200c177dff03abf58ad20ad2012b7bcfa7dc","BlockNumber":13,"BlockTimestamp":"2025-02-13T00:21:59Z","FinalizedBlockNumber":13,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x7af5c32b709324e54e6c5cda89f26453927ce6ecdfbc004eb1904e8548926c15","BlockNumber":14,"BlockTimestamp":"2025-02-13T00:22:00Z","FinalizedBlockNumber":14,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xa93a4ac54ac5b0230bc6f73b7aa8071f8ca53d1b27fa74e37f1fe006e44ad9c9","BlockNumber":15,"BlockTimestamp":"2025-02-13T00:22:01Z","FinalizedBlockNumber":15,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x48500647c7d0b6bd6be4574cc42a1a7b54fbcb7b5370410afbb7d3eb74aeab19","BlockNumber":16,"BlockTimestamp":"2025-02-13T00:22:02Z","FinalizedBlockNumber":16,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xa853e59cded51425261bc57c3f9e57730c5d93639d5a21e8930ecbbcefb236cf","BlockNumber":17,"BlockTimestamp":"2025-02-13T00:22:03Z","FinalizedBlockNumber":17,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xa9c6e1bec48b5860a10a45b0d6ace424ed965586857a636f5eebd121569cea6a","BlockNumber":18,"BlockTimestamp":"2025-02-13T00:22:04Z","FinalizedBlockNumber":18,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xda39226d4803507bacee154bbee929a94e20900684e4d9050d0e6d17a135a6b3","BlockNumber":19,"BlockTimestamp":"2025-02-13T00:22:05Z","FinalizedBlockNumber":19,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xa79805f1155a96d0348e58aec2db03c5e8e7218bf9e45a63be2841b9fc2449db","BlockNumber":20,"BlockTimestamp":"2025-02-13T00:22:06Z","FinalizedBlockNumber":20,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xe533cf50979b5777c5568d033cf6b08d66656b19097db37bf900e875eebc325b","BlockNumber":21,"BlockTimestamp":"2025-02-13T00:22:07Z","FinalizedBlockNumber":21,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x571ff8c7ff8c3bb227b601c7be8acfe9787400df021300257bc0e7175673046f","BlockNumber":22,"BlockTimestamp":"2025-02-13T00:22:08Z","FinalizedBlockNumber":22,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0x03120a30a3ee61b78ef61bbeced0da6133c2c13cd7c12c61e27d7935d739348b","BlockNumber":23,"BlockTimestamp":"2025-02-13T00:22:09Z","FinalizedBlockNumber":23,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xed07bb06f1bfc5e62029d74a0310c78cf90406e61133e03d31e664d0ed265a22","BlockNumber":24,"BlockTimestamp":"2025-02-13T00:22:10Z","FinalizedBlockNumber":24,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xb5e467629f9e8bdaf73ad6958a9907ef7d7e8737d339f8a04df3fac37a8d9be2","BlockNumber":25,"BlockTimestamp":"2025-02-13T00:22:11Z","FinalizedBlockNumber":25,"CreatedAt":"0001-01-01T00:00:00Z"},{"EvmChainId":null,"BlockHash":"0xb49be3e1d9ce0ffffd6f5c978d25533d6dff5bb79508d5dcef44dd59ceda4b6f","
</cicore>
  
    







<operatoruici>

## AER Report: [Operator UI CI](https://github.com/smartcontractkit/chainlink/actions/runs/13297507810) ran successfully :white_check_mark:

[aer_workflow](https://github.com/smartcontractkit/chainlink/actions/runs/13297527702/job/37132733073) , [commit](https://github.com/smartcontractkit/chainlink/commit/758b8fc8ec906edb8210e61ca17a7c46c29158e2)

</operatoruici>

RensR
RensR previously approved these changes Nov 22, 2024
@jmank88
Copy link
Contributor Author

jmank88 commented Nov 22, 2024

I thought that CI was just flaking, but this appears to legitimately break some log poller tests 🤔

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 188939d (geth-1.14.12).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestMain 0.00% true false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/gethwrappers true 0s @smartcontractkit/foundations, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and ae4137b (geth-1.14.12).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestMain 0.00% true false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/gethwrappers true 0s @smartcontractkit/foundations, @smartcontractkit/core

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@jmank88 jmank88 changed the title bump geth to v1.14.12 bump geth to v1.14.13 Jan 31, 2025
jmank88 and others added 2 commits February 12, 2025 18:15
core/gethwrappers: replace removed params.Version; make generate
@jmank88
Copy link
Contributor Author

jmank88 commented Feb 13, 2025

Closing in favor of #16369

1 similar comment
@jmank88
Copy link
Contributor Author

jmank88 commented Feb 13, 2025

Closing in favor of #16369

@jmank88 jmank88 closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants