Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPCORE-858]: feat: new distributor home page (NOT INTEGRATED) #84

Merged

Conversation

graham-chainlink
Copy link
Collaborator

Description

Since we now plan to support more than 1 feeds manager/job distributor, we want to have a home page where it shows a list of registered feeds managers. I also had to refactor the ConnectionStatus component out so i can reuse it in my new page.

Note: in order to keep my upcoming PRs small, this PR is purely for adding the react components for the brand new home page. They are currently not used yet. They will be used in the upcoming PR.

JIRA: https://smartcontract-it.atlassian.net/browse/OPCORE-858

Checklist

No Changeset needed as this is just adding a few files, no integration yet. When i integrate the new page, i will add the changeset.

Testing

New home page for job distributors

Screenshot 2024-08-31 at 12 21 36 PM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.10145% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (ggoh/OPCORE-891/rename-to-job-distributor@cfd4ce8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rc/screens/JobDistributor/JobDistributorScreen.tsx 92.85% 1 Missing ⚠️
src/screens/JobDistributor/JobDistributorView.tsx 94.44% 1 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##             ggoh/OPCORE-891/rename-to-job-distributor      #84   +/-   ##
============================================================================
  Coverage                                             ?   88.19%           
============================================================================
  Files                                                ?      247           
  Lines                                                ?     4508           
  Branches                                             ?      780           
============================================================================
  Hits                                                 ?     3976           
  Misses                                               ?      511           
  Partials                                             ?       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graham-chainlink graham-chainlink force-pushed the ggoh/OPCORE-858/new-job-distributor-home-page branch from 05ebc08 to 2f49e9e Compare August 31, 2024 03:58
Since we now plan to support more than 1 feeds manager/job distributor, we want to have a home page where it shows a list of registered feeds managers

JIRA: https://smartcontract-it.atlassian.net/browse/OPCORE-858
@graham-chainlink graham-chainlink force-pushed the ggoh/OPCORE-858/new-job-distributor-home-page branch from 2f49e9e to d74af46 Compare September 3, 2024 03:43
Base automatically changed from ggoh/OPCORE-891/rename-to-job-distributor to main September 3, 2024 06:02
@graham-chainlink graham-chainlink merged commit 619f389 into main Sep 3, 2024
7 checks passed
@graham-chainlink graham-chainlink deleted the ggoh/OPCORE-858/new-job-distributor-home-page branch September 3, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants