Skip to content

Commit

Permalink
Merge pull request #65 from smartcontractkit/fix/BCF-3321-fix-gh-work…
Browse files Browse the repository at this point in the history
…flows

Update linter to detect unused vars and sonar workflow to propagate linter issues
  • Loading branch information
patrickhuie19 authored Jul 18, 2024
2 parents c39b4a9 + 8ced63f commit e09a898
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/sonar-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
with:
workflow: ci-lint.yml
name: golangci-lint-report
workflow_conclusion: ""
if_no_artifact_found: warn

- name: Download go unit test coverage reports
Expand All @@ -55,6 +56,7 @@ jobs:
with:
workflow: ci-test.yml
name: go-test-results
workflow_conclusion: ""
if_no_artifact_found: warn

- name: Set SonarQube Report Paths
Expand Down
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ linters:
# These are all considered deprecated: https://github.com/golangci/golangci-lint/issues/1841
- deadcode
- structcheck
- unused
- varcheck
linters-settings:
exhaustive:
Expand Down

0 comments on commit e09a898

Please sign in to comment.