Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartvisu: Improve web interface #826

Merged
merged 6 commits into from
Dec 16, 2023
Merged

Conversation

onkelandy
Copy link
Member

No description provided.

@onkelandy onkelandy requested a review from msinn September 18, 2023 22:08
@@ -184,6 +184,8 @@ def parse_item(self, item):
item.expand_relativepathes('sv_widget2', "'", "'")
item.expand_relativepathes('sv_nav_aside', "'", "'")
item.expand_relativepathes('sv_nav_aside2', "'", "'")
if ('visu_acl' in item.conf):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wozu ist das gut? Das sollte die SmartPlugin Klasse doch eigentlich von selbst tun.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das expand_relativepathes..? Keine Ahnung - war schon drin. Soll ich die 3 Zeilen raus kicken? Hast du das getestet?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nein ich meinte

  if ('visu_acl' in item.conf):
    ...

Copy link
Member Author

@onkelandy onkelandy Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, ich hab's reverted.

'Letzte Aktualisierung': {'de': '=', 'en': 'Last Update'}
'Logik': {'de': '=', 'en': 'Logic'}
'Status': {'de': '=', 'en': '='}
'Item': {'de': '=', 'en': '='}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zumindest die Übersetzung für Item ist doppelt gemoppelt. Die gibt es doch bereits in den globalen Übersetzungen in bin/locale.yaml. Dort sogar mit französischer Übersetzung, was durch den Eintrag hier jedoch ausgeblendet wird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guter Hinweis, an das File hab ich nie gedacht.. da könnte man dann wohl noch einige andere Plugins säubern. Hab mal ein paar unnötige Übersetzungen rausgenommen.

@msinn msinn changed the title Smartvisu Plugin: Improve web interface smartvisu: Improve web interface Oct 31, 2023
@msinn msinn merged commit f6049d6 into smarthomeNG:develop Dec 16, 2023
5 checks passed
@onkelandy onkelandy deleted the smartvisu branch December 29, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants