-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smartvisu: Improve web interface #826
Conversation
smartvisu/__init__.py
Outdated
@@ -184,6 +184,8 @@ def parse_item(self, item): | |||
item.expand_relativepathes('sv_widget2', "'", "'") | |||
item.expand_relativepathes('sv_nav_aside', "'", "'") | |||
item.expand_relativepathes('sv_nav_aside2', "'", "'") | |||
if ('visu_acl' in item.conf): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wozu ist das gut? Das sollte die SmartPlugin Klasse doch eigentlich von selbst tun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das expand_relativepathes..? Keine Ahnung - war schon drin. Soll ich die 3 Zeilen raus kicken? Hast du das getestet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nein ich meinte
if ('visu_acl' in item.conf):
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, ich hab's reverted.
smartvisu/locale.yaml
Outdated
'Letzte Aktualisierung': {'de': '=', 'en': 'Last Update'} | ||
'Logik': {'de': '=', 'en': 'Logic'} | ||
'Status': {'de': '=', 'en': '='} | ||
'Item': {'de': '=', 'en': '='} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zumindest die Übersetzung für Item ist doppelt gemoppelt. Die gibt es doch bereits in den globalen Übersetzungen in bin/locale.yaml. Dort sogar mit französischer Übersetzung, was durch den Eintrag hier jedoch ausgeblendet wird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guter Hinweis, an das File hab ich nie gedacht.. da könnte man dann wohl noch einige andere Plugins säubern. Hab mal ein paar unnötige Übersetzungen rausgenommen.
No description provided.