SONOS: introduce item handling from smartplugin #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sisamiwe
commented
Nov 13, 2024
•
sisamiwe
commented
- bump to 1.8.8
- introduce item handling from smartplugin
- code cleanup
- update WebIF
Morg42
reviewed
Nov 14, 2024
| self.logger.debug(f"Item {item.property.path} registered to 'sonos_send' commands with '{item_attribute}'.") | ||
|
|
||
| if 'sonos_recv' in item_config or 'sonos_send' in item_config: | ||
| self.add_item(item, config_data_dict=item_config, updating=True) |
There was a problem hiding this comment.
mit updating=True werden Items immer auf updating gesetzt, bei sonos_recv und bei sonos_send.
Wenn das - siehe nächste Zeile - nur bei sonos_send passieren soll, hier updating=True weglassen, das wird für sonos_send durch die Item-Klasse automatisch gesetzt
Morg42
approved these changes
Nov 14, 2024
aschwith
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.