upgrade deps, update to go 1.18 #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go 1.18 is the most recent supported version of Go, so it seems reasonable to upgrade to that. This upgrade is needed to pull in the latest version of smartystreets/assertions, which I want in here for this fix of mine: smarty/assertions@a83f75f This also replaces all "interface{}" with "any", since go 1.18 added that. That was already done in the assertions repo the other day. Note that this command passes: go test -timeout=1s -race -cover -short -count=1 ./... but the integration test file fails. That failure is already in the repo at HEAD though.
|
FYI @riannucci or others |
|
lgtm will pull and tag when I'm at computer |
|
bump @riannucci 😄 |
|
(sorry for the delay!) |
|
Thanks, Robbie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go 1.18 is the most recent supported version of Go, so it seems reasonable to upgrade to that. This upgrade is needed to pull in the latest version of smartystreets/assertions, which I want in here for this fix of mine: smarty/assertions@a83f75f
This also replaces all "interface{}" with "any", since go 1.18 added that. That was already done in the assertions repo the other day.
Note that this command passes:
go test -timeout=1s -race -cover -short -count=1 ./...
but the integration test file fails. That failure is already in the repo at HEAD though.
This is a partial fix to #665, since it pulls in the aforementioned assertions fix. See smarty/assertions#50